[GPR] Removed GPR_BACKWARDS_COMPATIBILITY_MODE #35602
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veblush
added
area/core
kind/internal cleanup
release notes: yes
grpc-checks
bot
added
bloat/none
per-call-memory/neutral
per-channel-memory/neutral
labels
ctiller
approved these changes
Jan 19, 2024
grpc-checks
bot
added
per-call-memory/increase
and removed
per-call-memory/neutral
labels
yashykt
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GPR_BACKWARDS_COMPATIBILITY_MODEwas devised to support old Linux kernel with old glibc but gRPC is now expected to support glibc 2.17 and later (2.17 is derived from the oldest but supported Linux distro, CentOS 7). Effectively, gRPC doesn't needGPR_BACKWARDS_COMPATIBILITY_MODEanymore. Hence, let's remove it.gRPC Python and Ruby that distribute binary artifacts already began to use
manylinuxenvironment dealing with this issue in a better way so they don't need this flag anymore.