Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python Version] Drop support for Python 3.7 #34450

Closed
wants to merge 15 commits into from

Conversation

XuanWang-Amos
Copy link
Contributor

@XuanWang-Amos XuanWang-Amos commented Sep 22, 2023

NOTE

As part of supporting Python 3.12, we're now officially drop support for Python 3.7.

This PR:

  • Changed supported Python version from 3.7 to 3.8 in README.
  • Replaced distribution test image from debian:buster to debian:bullseye since the default Python version in buster is 3.7.

Copy link
Contributor

@gnossen gnossen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!

PythonArtifact(
"musllinux_1_1", "x86", "cp37-cp37m", presubmit=True
),
PythonArtifact("musllinux_1_1", "x86", "cp38-cp38"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is removing several 3.8 and 3.9 artifacts for Musl and Mac OS?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, those are not ordered by version for some reason, I re-ordered and moved them to above.

@XuanWang-Amos XuanWang-Amos requested review from gnossen and removed request for apolcyn and jtattermusch September 26, 2023 22:21
yashykt pushed a commit that referenced this pull request Oct 9, 2023
Bump Python windows distribtest timeout. With the addition of 3.12
artifacts, we've been hitting this timeout pretty frequently recently.
Once
[https://github.com/grpc/grpc/pull/34450](https://www.google.com/url?sa=D&q=https%3A%2F%2Fgithub.com%2Fgrpc%2Fgrpc%2Fpull%2F34450)
is merged, we'll have a reduction in total time, but even before 3.12
was introduced, we were already hitting the timeout pretty frequently.
gnossen added a commit that referenced this pull request Oct 30, 2023
Bump Python windows distribtest timeout. With the addition of 3.12
artifacts, we've been hitting this timeout pretty frequently recently.
Once
[https://github.com/grpc/grpc/pull/34450](https://www.google.com/url?sa=D&q=https%3A%2F%2Fgithub.com%2Fgrpc%2Fgrpc%2Fpull%2F34450)
is merged, we'll have a reduction in total time, but even before 3.12
was introduced, we were already hitting the timeout pretty frequently.
@copybara-service copybara-service bot closed this in 73b0ac2 Apr 8, 2024
veblush pushed a commit that referenced this pull request Apr 9, 2024
Typo introduced in: #34450
<!--

If you know who should review your pull request, please assign it to
that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the
appropriate
lang label.

-->
XuanWang-Amos added a commit to XuanWang-Amos/grpc that referenced this pull request Apr 12, 2024
* We shouldn't merge this PR until GCP cloud functions drops support for Python 3.7 ([Currently scheduled for GCF](https://cloud.google.com/functions/docs/runtime-support#python))

As part of supporting Python 3.12, we're now officially drop support for Python 3.7.

This PR:

* Changed supported Python version from 3.7 to 3.8 in README.
* Replaced distribution test image from `debian:buster` to `debian:bullseye` since the default Python version in buster is 3.7.

<!--

If you know who should review your pull request, please assign it to that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the appropriate
lang label.

-->

Closes grpc#34450

PiperOrigin-RevId: 622899511
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants