-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Python Version] Drop support for Python 3.7 #34450
Conversation
719ae1c
to
f7ea595
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this!
PythonArtifact( | ||
"musllinux_1_1", "x86", "cp37-cp37m", presubmit=True | ||
), | ||
PythonArtifact("musllinux_1_1", "x86", "cp38-cp38"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is removing several 3.8 and 3.9 artifacts for Musl and Mac OS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, those are not ordered by version for some reason, I re-ordered and moved them to above.
Bump Python windows distribtest timeout. With the addition of 3.12 artifacts, we've been hitting this timeout pretty frequently recently. Once [https://github.com/grpc/grpc/pull/34450](https://www.google.com/url?sa=D&q=https%3A%2F%2Fgithub.com%2Fgrpc%2Fgrpc%2Fpull%2F34450) is merged, we'll have a reduction in total time, but even before 3.12 was introduced, we were already hitting the timeout pretty frequently.
Bump Python windows distribtest timeout. With the addition of 3.12 artifacts, we've been hitting this timeout pretty frequently recently. Once [https://github.com/grpc/grpc/pull/34450](https://www.google.com/url?sa=D&q=https%3A%2F%2Fgithub.com%2Fgrpc%2Fgrpc%2Fpull%2F34450) is merged, we'll have a reduction in total time, but even before 3.12 was introduced, we were already hitting the timeout pretty frequently.
e45c129
to
bc30f58
Compare
Typo introduced in: #34450 <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. -->
* We shouldn't merge this PR until GCP cloud functions drops support for Python 3.7 ([Currently scheduled for GCF](https://cloud.google.com/functions/docs/runtime-support#python)) As part of supporting Python 3.12, we're now officially drop support for Python 3.7. This PR: * Changed supported Python version from 3.7 to 3.8 in README. * Replaced distribution test image from `debian:buster` to `debian:bullseye` since the default Python version in buster is 3.7. <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Closes grpc#34450 PiperOrigin-RevId: 622899511
NOTE
As part of supporting Python 3.12, we're now officially drop support for Python 3.7.
This PR:
debian:buster
todebian:bullseye
since the default Python version in buster is 3.7.