Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xds ssa] Remove environment variable protection for stateful affinity #34435

Merged
merged 4 commits into from
Sep 22, 2023

Conversation

eugeneo
Copy link
Contributor

@eugeneo eugeneo commented Sep 21, 2023

No description provided.

Copy link
Member

@markdroth markdroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for doing this!

@eugeneo eugeneo merged commit 2f78fff into grpc:master Sep 22, 2023
68 of 70 checks passed
@eugeneo eugeneo deleted the tasks/ssa-no-env-var branch September 22, 2023 20:07
@copybara-service copybara-service bot added the imported Specifies if the PR has been imported to the internal repository label Sep 23, 2023
@gnossen gnossen self-assigned this Sep 24, 2023
@gnossen
Copy link
Contributor

gnossen commented Sep 24, 2023

This PR introduced a regression in the SSA interop tests. It is not safe to remove the guarding env var from the interop templates in the same PR as we disable the usage of the env var on master. It is only safe to do so once all branches tested using the feature have backported the removal of the env var and all of those branches have completed their image build.

This will fix things for the moment.

sergiitk pushed a commit to sergiitk/grpc that referenced this pull request Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bloat/none imported Specifies if the PR has been imported to the internal repository lang/c++ lang/core per-call-memory/neutral per-channel-memory/neutral release notes: yes Indicates if PR needs to be in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants