[csharp codegen] Handle empty base_namespace option value to fix #34113 #34137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grpc-checks
bot
added
per-call-memory/neutral
per-channel-memory/neutral
bloat/none
labels
|
@jtattermusch for review |
jtattermusch
added
the
release notes: yes
jtattermusch
approved these changes
Aug 29, 2023
jtattermusch
added
release notes: yes
jtattermusch
changed the title
copybara-service
bot
added
the
imported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #34113 - setting C# option base_namespace to an empty string results in inconsistent behavior
Allow the
base_namespaceoption in the protocol buffers C# gRPC plugin to be specified with an empty string to make sure the plugin has the same behaviour as the protocol buffers compiler.