[EventEngine] Change GetDNSResolver to return absl::StatusOr<std::unique_ptr<DNSResolver>>
#33744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absl::StatusOr<std::unique_ptr<DNSResolver>> GetDNSResolver
grpc-checks
bot
added
per-call-memory/neutral
per-channel-memory/neutral
bloat/low
labels
drfloob
reviewed
Jul 18, 2023
markdroth
approved these changes
Jul 18, 2023
drfloob
approved these changes
Jul 18, 2023
yijiem
added
kokoro:force-run
and removed
disposition/Needs Internal Changes
kokoro:force-run
labels
copybara-service
bot
added
the
imported
mario-vimal
pushed a commit
to mario-vimal/grpc
that referenced
this pull request
Jul 27, 2023
…unique_ptr<DNSResolver>>` (grpc#33744) Based on the discussion at: https://github.com/grpc/grpc/pull/32701/files/595a75cc5d56f8d7341a9533a24428ad37810269..e3b402a8fa27fc8787a73775068721bf9f322640#r1244325752 <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the discussion at: https://github.com/grpc/grpc/pull/32701/files/595a75cc5d56f8d7341a9533a24428ad37810269..e3b402a8fa27fc8787a73775068721bf9f322640#r1244325752