[ssl] Fix SSL stack to handle large handshake messages whose length exceeds the BIO buffer size. #33638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewstevenson88
changed the title
matthewstevenson88
added
release notes: yes
grpc-checks
bot
added
per-call-memory/neutral
per-channel-memory/neutral
bloat/none
labels
|
@zeromath Could you also take a quick look at this PR? |
zeromath
reviewed
Jul 10, 2023
zeromath
reviewed
Jul 10, 2023
erm-g
approved these changes
Jul 10, 2023
|
LGTM! (I didn't find a button for this, maybe it's because I don't have the permission to do so.) |
|
@markdroth Friendly ping. :) |
markdroth
reviewed
Jul 18, 2023
markdroth
approved these changes
Jul 18, 2023
markdroth
approved these changes
Jul 18, 2023
|
Thanks all for the reviews! |
copybara-service
bot
added
the
imported
matthewstevenson88
added a commit
that referenced
this pull request
Jul 24, 2023
…3824) This PR is expected to fix the flakes of `//test/core/tsi:ssl_transport_security_test` when built under UBSAN. Why is this needed? There are several tests in `ssl_transport_security_test.cc` that involve doing many expensive operations and PR #33638 recently added one more (namely, repeatedly signing with an ECDSA key). The slow tests are already altered for MSAN and TSAN, and now we need to do the same for UBSAN.
mario-vimal
pushed a commit
to mario-vimal/grpc
that referenced
this pull request
Jul 27, 2023
…xceeds the BIO buffer size. (grpc#33638) There is a bug in the SSL stack that was only partially fixed in grpc#29176: if more than 17kb is written to the BIO buffer, then everything over 17kb will be discarded, and the SSL handshake will fail with a bad record mac error or hang if not enough bytes have arrived yet. It's relatively uncommon to hit this bug, because the TLS handshake messages need to be much larger than normal for you to have a chance of hitting this bug. However, there was a separate bug in the SSL stack (recently fixed in grpc#33558) that causes the ServerHello produced by a gRPC-C++ TLS server to grow linearly in size with the size of the trust bundle; these 2 bugs combined to cause a large number of TLS handshake failures for gRPC-C++ clients talking to gRPC-C++ servers when the server had a large trust bundle. This PR fixes the bug by ensuring that all bytes are successfully written to the BIO buffer. An initial quick fix for this bug was planned in grpc#33611, but abandoned because we were worried about temporarily doubling the memory footprint of all SSL channels. The complexity in this PR is mostly in the test: it is fairly tricky to force gRPC-C++'s SSL stack to generate a sufficiently large ServerHello to trigger this bug.
mario-vimal
pushed a commit
to mario-vimal/grpc
that referenced
this pull request
Jul 27, 2023
…pc#33824) This PR is expected to fix the flakes of `//test/core/tsi:ssl_transport_security_test` when built under UBSAN. Why is this needed? There are several tests in `ssl_transport_security_test.cc` that involve doing many expensive operations and PR grpc#33638 recently added one more (namely, repeatedly signing with an ECDSA key). The slow tests are already altered for MSAN and TSAN, and now we need to do the same for UBSAN.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in the SSL stack that was only partially fixed in #29176: if more than 17kb is written to the BIO buffer, then everything over 17kb will be discarded, and the SSL handshake will fail with a bad record mac error or hang if not enough bytes have arrived yet.
It's relatively uncommon to hit this bug, because the TLS handshake messages need to be much larger than normal for you to have a chance of hitting this bug. However, there was a separate bug in the SSL stack (recently fixed in #33558) that causes the ServerHello produced by a gRPC-C++ TLS server to grow linearly in size with the size of the trust bundle; these 2 bugs combined to cause a large number of TLS handshake failures for gRPC-C++ clients talking to gRPC-C++ servers when the server had a large trust bundle.
This PR fixes the bug by ensuring that all bytes are successfully written to the BIO buffer. An initial quick fix for this bug was planned in #33611, but abandoned because we were worried about temporarily doubling the memory footprint of all SSL channels.
The complexity in this PR is mostly in the test: it is fairly tricky to force gRPC-C++'s SSL stack to generate a sufficiently large ServerHello to trigger this bug.