Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[otel] Add bazel dependency #33548

Merged
merged 4 commits into from
Jun 27, 2023
Merged

[otel] Add bazel dependency #33548

merged 4 commits into from
Jun 27, 2023

Conversation

yashykt
Copy link
Member

@yashykt yashykt commented Jun 26, 2023

Add bazel dependency on opentelemetry-cpp.

@yashykt yashykt marked this pull request as ready for review June 26, 2023 18:38
@yashykt yashykt added the release notes: yes Indicates if PR needs to be in release notes label Jun 26, 2023
"otel/sdk/src/metrics",
],
language = "C++",
linkstatic = True,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this required?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dunno, I just copied it over. I'll remove it

@yashykt yashykt enabled auto-merge (squash) June 27, 2023 07:03
@yashykt yashykt merged commit 875b7fd into grpc:master Jun 27, 2023
55 of 65 checks passed
markdroth added a commit that referenced this pull request Jun 27, 2023
yashykt pushed a commit that referenced this pull request Jun 27, 2023
@copybara-service copybara-service bot added the imported Specifies if the PR has been imported to the internal repository label Jun 27, 2023
mario-vimal pushed a commit to mario-vimal/grpc that referenced this pull request Jul 13, 2023
Add bazel dependency on opentelemetry-cpp.
<!--

If you know who should review your pull request, please assign it to
that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the
appropriate
lang label.

-->
mario-vimal pushed a commit to mario-vimal/grpc that referenced this pull request Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bloat/none imported Specifies if the PR has been imported to the internal repository lang/c++ per-call-memory/neutral per-channel-memory/neutral release notes: yes Indicates if PR needs to be in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants