[HTTP2] Fix inconsistencies in keepalive configuration #33428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashykt
changed the title
yashykt
added
the
release notes: yes
|
This seems like an ideal time to add tests around the expected configuration. |
|
what kind of tests are you imagining? |
grpc-checks
bot
added
per-call-memory/neutral
per-channel-memory/neutral
bloat/none
labels
|
a set of asserts that would trigger if, say, we disabled keep alives but scheduled at INT_MAX seconds regardless? |
ctiller
reviewed
Jun 16, 2023
ctiller
approved these changes
Jun 16, 2023
copybara-service
bot
added
the
imported
yashykt
added a commit
that referenced
this pull request
Jun 30, 2023
…n ( #33428)" (#33512) (#33586) Along with an experiment this time <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. -->
HannahShiSFB
pushed a commit
to HannahShiSFB/grpc
that referenced
this pull request
Jul 3, 2023
…n ( grpc#33428)" (grpc#33512) (grpc#33586) Along with an experiment this time <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. -->
yashykt
added a commit
that referenced
this pull request
Jul 5, 2023
yashykt
added a commit
that referenced
this pull request
Jul 5, 2023
yashykt
added a commit
that referenced
this pull request
Jul 5, 2023
mario-vimal
pushed a commit
to mario-vimal/grpc
that referenced
this pull request
Jul 5, 2023
…n ( grpc#33428)" (grpc#33512) (grpc#33586) Along with an experiment this time <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. -->
mario-vimal
pushed a commit
to mario-vimal/grpc
that referenced
this pull request
Jul 5, 2023
…iguration ( grpc#33428)" (grpc#33512)" (grpc#33599) Reverts grpc#33586 Looks like this has to be cherry-picked
yashykt
added a commit
that referenced
this pull request
Jul 6, 2023
mario-vimal
pushed a commit
to mario-vimal/grpc
that referenced
this pull request
Jul 13, 2023
…33428)" (grpc#33512) This reverts commit e107ff5. <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. -->
mario-vimal
pushed a commit
to mario-vimal/grpc
that referenced
this pull request
Jul 13, 2023
…n ( grpc#33428)" (grpc#33512) (grpc#33586) Along with an experiment this time <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. -->
mario-vimal
pushed a commit
to mario-vimal/grpc
that referenced
this pull request
Jul 13, 2023
…iguration ( grpc#33428)" (grpc#33512)" (grpc#33599) Reverts grpc#33586 Looks like this has to be cherry-picked
mario-vimal
pushed a commit
to mario-vimal/grpc
that referenced
this pull request
Jul 13, 2023
…ive configuration ( grpc#33428)" (grpc#33512)"" (grpc#33601) Reverts grpc#33599 Needs to be cherry-picked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed some inconsistencies in our keepalive configuration -
g_default_client_keepalive_permit_without_calls/g_default_server_keepalive_permit_without_calls. They are both false by default but they can be overridden ingrpc_chttp2_config_default_keepalive_args.