[Audit Logging] Second attempt: rbac service config parsing with audit logging #33183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockspore
added
release notes: no
grpc-checks
bot
added
per-call-memory/neutral
per-channel-memory/neutral
bloat/low
labels
…bac service config parser" (grpc#33178)" This reverts commit 922b18f.
rockspore
force-pushed
the
service-config-parser-fix
branch
from
54b535a
to
f4305e9
Compare
markdroth
approved these changes
May 18, 2023
copybara-service
bot
added
the
imported
eugeneo
pushed a commit
to eugeneo/grpc
that referenced
this pull request
May 19, 2023
…t logging (grpc#33183) This is basically the same as grpc#33145 except that the ctor `Rules()` cannot be default but have to explicitly set a default audit condition.
yijiem
added
release notes: yes
erm-g
removed
the
release notes: yes
yijiem
added
the
release notes: no
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically the same as #33145 except that the ctor
Rules()cannot be default but have to explicitly set a default audit condition.