Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[example] Server reflection #33162

Merged
merged 2 commits into from May 17, 2023
Merged

[example] Server reflection #33162

merged 2 commits into from May 17, 2023

Conversation

drfloob
Copy link
Member

@drfloob drfloob commented May 17, 2023 •
edited

This is nearly identical to the helloworld example's greeter callback server, but without the health check service enabled. Having a separate example for reflection may help folks find this code.

@drfloob drfloob requested review from eugeneo and veblush May 17, 2023 19:05
@drfloob drfloob added release notes: yes Indicates if PR needs to be in release notes lang/c++ and removed lang/c++ labels May 17, 2023
eugeneo
eugeneo approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@eugeneo eugeneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there also be an example for how clients can use the reflection? Would be really helpful to tools developers.

@drfloob
Copy link
Member Author

drfloob commented May 17, 2023

Should there also be an example for how clients can use the reflection? Would be really helpful to tools developers.

For consistency with the other gRPC implementations, only server-side reflection examples have been created. See go's and java's examples for comparison.

@drfloob drfloob merged commit cf6e5ed into grpc:master May 17, 2023
56 of 61 checks passed
@drfloob drfloob deleted the reflection-example branch May 17, 2023 20:12
wanlin31 pushed a commit that referenced this pull request May 18, 2023
@drfloob @wanlin31
[example] Server reflection (#33162)
3445e68 
This is nearly identical to the helloworld example's greeter callback
server, but without the health check service enabled. Having a separate
example for reflection may help folks find this code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eugeneo eugeneo eugeneo approved these changes

@veblush veblush Awaiting requested review from veblush

Assignees
No one assigned
Labels
lang/c++ release notes: yes Indicates if PR needs to be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@drfloob @eugeneo