[xDS] Protect RBAC audit logging options field with environment variable. #33004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockspore
added
the
release notes: no
markdroth
reviewed
May 3, 2023
markdroth
approved these changes
May 3, 2023
rockspore
changed the title
copybara-service
bot
added
the
imported
nanahpang
pushed a commit
to nanahpang/grpc
that referenced
this pull request
May 8, 2023
…ble. (grpc#33004) The protection is added at `xds_http_rbac_filter.cc` where we read the new field. With this disabling the feature, nothing from things like `xds_audit_logger_registry.cc` shall be invoked.
wanlin31
pushed a commit
that referenced
this pull request
May 18, 2023
…ble. (#33004) The protection is added at `xds_http_rbac_filter.cc` where we read the new field. With this disabling the feature, nothing from things like `xds_audit_logger_registry.cc` shall be invoked.
yijiem
added
release notes: yes
erm-g
removed
the
release notes: yes
yijiem
added
the
release notes: no
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The protection is added at
xds_http_rbac_filter.ccwhere we read the new field. With this disabling the feature, nothing from things likexds_audit_logger_registry.ccshall be invoked.