[EventEngine] Update contract for Listener's on_shutdown execution #33003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drfloob
added
release notes: yes
Vignesh2208
approved these changes
May 3, 2023
grpc-checks
bot
added
per-call-memory/neutral
per-channel-memory/neutral
bloat/none
labels
copybara-service
bot
added
the
imported
paulosjca
pushed a commit
to paulosjca/grpc
that referenced
this pull request
May 4, 2023
…rpc#33003) See `event_engine.h` for the contract change. All other changes are cleanup. I confirmed that both the Posix and Windows implementations comply with this already. On Windows, the `WindowsEventEngineListener` will only call `on_shutdown` after all `SinglePortSocketListener`s have been destroyed, which ensures that no `on_accept` callback will be executed, even if there is still trailing overlapped activity on the listening socket. On Posix, the `PosixEngineListenerImpl` will only call `on_shutdown` after all `AsyncConnectionAcceptor`s have been destroyed, which ensures `EventHandle::OrphanHandle` has been called. The `OrphanHandle` contract indicates that all existing notify closures must have already run. The implementation looks to comply, so if it does not, that's a bug. https://github.com/grpc/grpc/blob/3aae08d25e69af36445de7618072d708d839642d/src/core/lib/event_engine/posix_engine/event_poller.h#L48-L50
wanlin31
pushed a commit
that referenced
this pull request
May 18, 2023
…33003) See `event_engine.h` for the contract change. All other changes are cleanup. I confirmed that both the Posix and Windows implementations comply with this already. On Windows, the `WindowsEventEngineListener` will only call `on_shutdown` after all `SinglePortSocketListener`s have been destroyed, which ensures that no `on_accept` callback will be executed, even if there is still trailing overlapped activity on the listening socket. On Posix, the `PosixEngineListenerImpl` will only call `on_shutdown` after all `AsyncConnectionAcceptor`s have been destroyed, which ensures `EventHandle::OrphanHandle` has been called. The `OrphanHandle` contract indicates that all existing notify closures must have already run. The implementation looks to comply, so if it does not, that's a bug. https://github.com/grpc/grpc/blob/3aae08d25e69af36445de7618072d708d839642d/src/core/lib/event_engine/posix_engine/event_poller.h#L48-L50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See
event_engine.hfor the contract change. All other changes are cleanup.I confirmed that both the Posix and Windows implementations comply with this already.
On Windows, the
WindowsEventEngineListenerwill only callon_shutdownafter allSinglePortSocketListeners have been destroyed, which ensures that noon_acceptcallback will be executed, even if there is still trailing overlapped activity on the listening socket.On Posix, the
PosixEngineListenerImplwill only callon_shutdownafter allAsyncConnectionAcceptors have been destroyed, which ensuresEventHandle::OrphanHandlehas been called. TheOrphanHandlecontract indicates that all existing notify closures must have already run. The implementation looks to comply, so if it does not, that's a bug.grpc/src/core/lib/event_engine/posix_engine/event_poller.h
Lines 48 to 50 in 3aae08d