Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compiler Fix] Bring declarations and definitions to be in sync #32911

Merged
merged 1 commit into from Apr 21, 2023

Conversation

yashykt
Copy link
Member

@yashykt yashykt commented Apr 21, 2023

Fix #32881

@mint570
Copy link
Contributor

mint570 commented Apr 21, 2023

This PR fixes the linking issue in our setup.

@yashykt yashykt requested a review from veblush April 21, 2023 16:17
@yashykt yashykt merged commit ed5e456 into grpc:master Apr 21, 2023
63 of 64 checks passed
@copybara-service copybara-service bot added the imported Specifies if the PR has been imported to the internal repository label Apr 21, 2023
yashykt added a commit to yashykt/grpc that referenced this pull request Apr 21, 2023
…#32911)

<!--

If you know who should review your pull request, please assign it to
that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the
appropriate
lang label.

-->
yashykt added a commit to yashykt/grpc that referenced this pull request Apr 21, 2023
…#32911)

<!--

If you know who should review your pull request, please assign it to
that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the
appropriate
lang label.

-->
yashykt added a commit that referenced this pull request Apr 21, 2023
… sync (#32911) (#32915)

<!--

If you know who should review your pull request, please assign it to
that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the
appropriate
lang label.

-->




<!--

If you know who should review your pull request, please assign it to
that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the
appropriate
lang label.

-->
yashykt added a commit that referenced this pull request Apr 21, 2023
…) (#32916)

<!--

If you know who should review your pull request, please assign it to
that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the
appropriate
lang label.

-->




<!--

If you know who should review your pull request, please assign it to
that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the
appropriate
lang label.

-->
XuanWang-Amos pushed a commit to XuanWang-Amos/grpc that referenced this pull request May 1, 2023
…#32911)

<!--

If you know who should review your pull request, please assign it to
that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the
appropriate
lang label.

-->
wanlin31 pushed a commit that referenced this pull request May 18, 2023
<!--

If you know who should review your pull request, please assign it to
that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the
appropriate
lang label.

-->
@yashykt yashykt deleted the FixUndefinedReference branch May 18, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bloat/none imported Specifies if the PR has been imported to the internal repository lang/core per-call-memory/neutral per-channel-memory/neutral release notes: yes Indicates if PR needs to be in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

undefined reference to grpc_core::MetadataQuery::kIPv6Attribute
3 participants