[GcpObservability C++] Backport: De-experimentalize API (#32715) #32813
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to de-experimentalize the APIs for GCP Observability.
We would have ideally wanted public feedback before declaring the APIs stable, but we need stable APIs for GA.
Changes made after API review with @markdroth @veblush, @ctiller and the entire Core/C++ team -
grpc::experimental::GcpObservabilityInit
andgrpc::experimental::GcpObservabilityClose
are now deprecated and will be deleted after v.1.55 release.grpc::GcpObservability::Init()
call that returns anGcpObservability
object, the lifetime of which controls when observability data is flushed.GcpObservability
class could in the future add more methods. For example, a debug method that shows the current configuration.GcpObservability
destruction) are blocking calls.GcpObservability
destruction.Additional Implementation details -
GcpObservability::Init
is now marked withGRPC_MUST_USE_RESULT
to make sure that the results are used. We ideally want users to store it, but this is better than nothing.