Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EventEngine] Add EventEngine::*Handle equality operators #32695

Merged
merged 5 commits into from
Mar 23, 2023

Conversation

drfloob
Copy link
Member

@drfloob drfloob commented Mar 23, 2023

This allows us to replace absl::optional<TaskHandle> with checks against the invalid handle.

This PR also replaces the differently-named invalid handle instances with a uniform way of accessing static invalid instances across all handle types, which aids a bit in testing.

@drfloob drfloob requested a review from markdroth as a code owner March 23, 2023 20:33
@drfloob drfloob merged commit 3fe678e into grpc:master Mar 23, 2023
@copybara-service copybara-service bot added the imported Specifies if the PR has been imported to the internal repository label Mar 24, 2023
XuanWang-Amos pushed a commit to XuanWang-Amos/grpc that referenced this pull request May 1, 2023
This allows us to replace `absl::optional<TaskHandle>` with checks
against the invalid handle.

This PR also replaces the differently-named invalid handle instances
with a uniform way of accessing static invalid instances across all
handle types, which aids a bit in testing.
wanlin31 pushed a commit that referenced this pull request May 18, 2023
This allows us to replace `absl::optional<TaskHandle>` with checks
against the invalid handle.

This PR also replaces the differently-named invalid handle instances
with a uniform way of accessing static invalid instances across all
handle types, which aids a bit in testing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bloat/low imported Specifies if the PR has been imported to the internal repository lang/core lang/Python per-call-memory/neutral per-channel-memory/neutral release notes: yes Indicates if PR needs to be in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants