Switch all VS2017 builds to VS2019 #32662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grpc-checks
bot
added
per-call-memory/neutral
per-channel-memory/neutral
bloat/none
labels
jtattermusch
added
the
release notes: no
jtattermusch
force-pushed
the
vs2019_switch
branch
from
8085c6e
to
e608210
Compare
jtattermusch
force-pushed
the
vs2019_switch
branch
from
e608210
to
02a85fa
Compare
|
With the upgraded version of win2019 image from cl/518798103, all tests are passing now. |
veblush
approved these changes
Mar 23, 2023
copybara-service
bot
added
the
imported
jtattermusch
added a commit
to jtattermusch/grpc
that referenced
this pull request
Mar 24, 2023
(part of removing support for VS2017) Also see grpc#32649 Also see grpc#32615 The switch to grpc-win2019 windows workers has already happened: (cl/517400022). Once this PR lands, I'll backport to 1.53.x branch as well (since that release removes the VS2017 support).
jtattermusch
added a commit
that referenced
this pull request
Mar 24, 2023
|
This PR seems to have broken the Windows portability test. |
Good catch, I'm working on a fix. |
This was referenced Mar 27, 2023
jtattermusch
added a commit
to jtattermusch/grpc
that referenced
this pull request
Apr 5, 2023
…pc#32764) Tentative fix for b/275694647. Also see grpc#32662 Adhoc windows/grpc_portability run: http://sponge/bb75e14c-fc77-45bb-89bd-4c4685746490 Once merged, I'll backport to 1.54.x and 1.53.x (these have switched to VS2019)
jtattermusch
added a commit
to jtattermusch/grpc
that referenced
this pull request
Apr 5, 2023
…pc#32764) Tentative fix for b/275694647. Also see grpc#32662 Adhoc windows/grpc_portability run: http://sponge/bb75e14c-fc77-45bb-89bd-4c4685746490 Once merged, I'll backport to 1.54.x and 1.53.x (these have switched to VS2019)
XuanWang-Amos
pushed a commit
to XuanWang-Amos/grpc
that referenced
this pull request
May 1, 2023
(part of removing support for VS2017) Also see grpc#32649 Also see grpc#32615 The switch to grpc-win2019 windows workers has already happened: (cl/517400022). Once this PR lands, I'll backport to 1.53.x branch as well (since that release removes the VS2017 support).
XuanWang-Amos
pushed a commit
to XuanWang-Amos/grpc
that referenced
this pull request
May 1, 2023
…pc#32764) Tentative fix for b/275694647. Also see grpc#32662 Adhoc windows/grpc_portability run: http://sponge/bb75e14c-fc77-45bb-89bd-4c4685746490 Once merged, I'll backport to 1.54.x and 1.53.x (these have switched to VS2019)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(part of removing support for VS2017)
Also see #32649
Also see #32615
The switch to grpc-win2019 windows workers has already happened: (cl/517400022).
Once this PR lands, I'll backport to 1.53.x branch as well (since that release removes the VS2017 support).