Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ruby] fix re2 compilation when older system version installed #32580

Merged
merged 4 commits into from
May 16, 2023

Commits on Mar 9, 2023

  1. Fix re2 compilation when older system version installed

    re2 previously failed to compile if:
    
    1. An old `re2` version is installed with a non-standard system
    prefix, such as `/opt/local`.
    2. The environment variable is set: `CPPFLAGS=-I/opt/local/include`.
    
    Running `make` would result in function prototype mismatches because
    the Makefile would previously attempt to use the headers from
    `/opt/local/include/re2` before the `third_party/re2/re2`
    directory.
    
    To ensure the current directories receive priority, include the
    relevant re2 directories in the include path.
    stanhu committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    37a6ff0 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2023

  1. Configuration menu
    Copy the full SHA
    8cc4ac4 View commit details
    Browse the repository at this point in the history
  2. ruby: Avoid environment flags when building gprc code

    grpc#27660 caused `CPPFLAGS` to inherit
    from the environment, but this can cause the Makefile to use external
    include files for re2 and other libraries if `-I` flags are defined.
    
    This commit reverts to the original behavior of only using
    `RbConfig::CONFIG` values to avoid using the wrong headers.
    stanhu committed Mar 18, 2023
    Configuration menu
    Copy the full SHA
    857897a View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2023

  1. ruby: use environment variables for AR, CC, CXX, RANLIB, STRIP

    This makes it possible to override the compiler and other programs.
    stanhu committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    135c68e View commit details
    Browse the repository at this point in the history