feat: Auth lib: Remove 3PI config url validation #32450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@BigTailWolf please sign the CLA. Login to the EasyCLA using your @google.com email. @veblush I do not see any issues with this PR, can you take a look as well. Should this be added to the release notes? |
|
@eugeneo Signed in. |
veblush
added
release notes: no
|
Thanks for the PR! I think this is the rollback of #26966 and the corresponding unit test might need to be removed. |
grpc-checks
bot
added
per-call-memory/neutral
per-channel-memory/neutral
bloat/none
labels
veblush
approved these changes
Mar 9, 2023
copybara-service
bot
added
the
imported
XuanWang-Amos
pushed a commit
to XuanWang-Amos/grpc
that referenced
this pull request
May 1, 2023
To support TPC feature for BYOID (3PI), we need to remove the validation the pattern of impersonation endpoints, sts endpoints and token info endpoints since they are different in TPC regions. A security review is already passed at b/261634871 <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. -->
wanlin31
pushed a commit
that referenced
this pull request
May 18, 2023
To support TPC feature for BYOID (3PI), we need to remove the validation the pattern of impersonation endpoints, sts endpoints and token info endpoints since they are different in TPC regions. A security review is already passed at b/261634871 <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support TPC feature for BYOID (3PI), we need to remove the validation the pattern of impersonation endpoints, sts endpoints and token info endpoints since they are different in TPC regions.
A security review is already passed at b/261634871