[http2] Dont drop connections on metadata limit exceeded #32309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctiller
added
the
release notes: no
ctiller
changed the title
yashykt
reviewed
Feb 7, 2023
| grpc_call_unref(s); | ||
|
|
||
| grpc_slice_unref(meta.value); | ||
| } |
There was a problem hiding this comment.
maybe also do a ping to make sure that the channel is still connected?
yashykt
approved these changes
Feb 7, 2023
grpc-checks
bot
added
per-call-memory/neutral
per-channel-memory/neutral
bloat/none
labels
soheilhy
approved these changes
Feb 7, 2023
Automated fix for refs/heads/repeated_large_metadata
copybara-service
bot
added
the
imported
ctiller
added
release notes: yes
XuanWang-Amos
pushed a commit
to XuanWang-Amos/grpc
that referenced
this pull request
May 1, 2023
* [http] Dont drop connections on metadata limit exceeded * remove bad test * Automated change: Fix sanity tests --------- Co-authored-by: ctiller <ctiller@users.noreply.github.com>
wanlin31
pushed a commit
that referenced
this pull request
May 18, 2023
* [http] Dont drop connections on metadata limit exceeded * remove bad test * Automated change: Fix sanity tests --------- Co-authored-by: ctiller <ctiller@users.noreply.github.com>
This was referenced Jun 9, 2023
This was referenced Jun 11, 2023
This was referenced Jul 11, 2023
jpuhlman
pushed a commit
to MontaVista-OpenSourceTechnology/meta-openembedded
that referenced
this pull request
Jul 24, 2023
Source: meta-openembedded MR: 126092 Type: Integration Disposition: Merged from meta-openembedded ChangeID: d7ece8b Description: It was introduced in in v1.53.0 and not backported to v1.46.x branch. NVD references PR which intrioduces the vulnerability: grpc/grpc#32309 (comment) Signed-off-by: Peter Marko <peter.marko@siemens.com> Signed-off-by: Armin Kuster <akuster808@gmail.com> Signed-off-by: Jeremy A. Puhlman <jpuhlman@mvista.com>
|
@ctiller Sorry, but I'm a little confused. Which one is correct? |
This was referenced Dec 12, 2023
This was referenced Dec 12, 2023
Closed
Closed
This was referenced Dec 30, 2023
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we get an error on a stream, all we need to do is cancel that stream.
If instead we get an error not associated with a stream, we should close the transport.
Current behavior was to just close the transport always, and this was a bad bug.