Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support python 3.11 on aarch64 #32270

Merged
merged 3 commits into from Feb 6, 2023

Conversation

mgu
Copy link
Contributor

@mgu mgu commented Feb 2, 2023

Fixes #30927

I've build the artifact on amd64 and tested the wheel on Mac M1.

I'm not sure about what do do with grpc_artifact_python_manylinux2014_aarch64.current_version

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 2, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: mgu / name: Mickaël Guérin (595f3f8)

@mgu
Copy link
Contributor Author

mgu commented Feb 2, 2023

cc @gnossen

@gnossen
Copy link
Contributor

gnossen commented Feb 2, 2023

Super excited to see this PR! Thank you for the contribution.

@gnossen gnossen assigned gnossen and unassigned yashykt Feb 2, 2023
@gnossen gnossen enabled auto-merge (squash) February 2, 2023 21:24
@gnossen gnossen disabled auto-merge February 2, 2023 22:08
@mgu
Copy link
Contributor Author

mgu commented Feb 4, 2023

Thank you for adding the tag, I was not sure because some images don't have one

@gnossen
Copy link
Contributor

gnossen commented Feb 6, 2023

@mgu I think what you've already done is above and beyond the call of duty. The last bit will be fiddly CI-specific stuff that I'll take care of. Thank you very much for the contribution!

@gnossen gnossen enabled auto-merge (squash) February 6, 2023 20:08
@gnossen gnossen merged commit 56ad4d9 into grpc:master Feb 6, 2023
@mgu mgu deleted the fix-python_manylinux2014_aarch64-artifacts branch February 6, 2023 20:54
@copybara-service copybara-service bot added the imported Specifies if the PR has been imported to the internal repository label Feb 6, 2023
@ewdurbin
Copy link

ewdurbin commented Apr 3, 2023

Thanks so much to the many folks who were involved in seeing this through. This is a huge improvement in my day to day quality of life working on PyPI. 💜

XuanWang-Amos pushed a commit to XuanWang-Amos/grpc that referenced this pull request May 1, 2023
* Support python 3.11 on aarch64

Fixes grpc#30927

* Change base tag to something more specific

* Update current version

---------

Co-authored-by: Richard Belleville <rbellevi@google.com>
wanlin31 pushed a commit that referenced this pull request May 18, 2023
* Support python 3.11 on aarch64

Fixes #30927

* Change base tag to something more specific

* Update current version

---------

Co-authored-by: Richard Belleville <rbellevi@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/packaging & distribution bloat/none imported Specifies if the PR has been imported to the internal repository lang/Python per-call-memory/neutral per-channel-memory/neutral release notes: yes Indicates if PR needs to be in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support 3.11 on aarch64
5 participants