Fix Python epoll1 Fork Support #32196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnossen
added
kind/bug
lang/Python
area/test
lang/core
release notes: yes
grpc-checks
bot
added
per-call-memory/neutral
per-channel-memory/neutral
bloat/none
labels
drfloob
reviewed
Jan 26, 2023
There was a problem hiding this comment.
This is great, Richard! Have you confirmed this iteration order fix yet with the external reproductions?
@Vignesh2208 we'll still need to do some work to decouple the PosixEventEngine from the iomgr fork handlers. But we'll soon have some tests that'll help us do that safely.
I have specifically confirmed that this fixes the issue for Ray on Mac OS. |
gnossen
commented
Jan 27, 2023
drfloob
reviewed
Jan 27, 2023
copybara-service
bot
added
the
imported
XuanWang-Amos
pushed a commit
to XuanWang-Amos/grpc
that referenced
this pull request
May 1, 2023
* WIP. A seemingly properly failing test * WIP. Pre-fork handlers now work * Roughly working. * Clean up * Clean up more * Add to CI * Format * Ugh. Remove swap file * And another * clean up * Add copyright * Format * Remove another debug line * Add stub forkable methods * Remove use of 3.9+ function * Remove unintentional double copyright * drfloob review comments * Only hold lock during Close once * Create separate job for fork test * Bump up gdb timeout * Format
wanlin31
pushed a commit
that referenced
this pull request
May 18, 2023
* WIP. A seemingly properly failing test * WIP. Pre-fork handlers now work * Roughly working. * Clean up * Clean up more * Add to CI * Format * Ugh. Remove swap file * And another * clean up * Add copyright * Format * Remove another debug line * Add stub forkable methods * Remove use of 3.9+ function * Remove unintentional double copyright * drfloob review comments * Only hold lock during Close once * Create separate job for fork test * Bump up gdb timeout * Format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves several issues in core impacting fork support in Python. It also reenables and improves the existing Python-layer fork test.