xDS: fix WeightedClusters total weight handling #32134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
markdroth
commented
Jan 18, 2023
markdroth
commented
- Make sure we properly handle total weights up to uint32_max.
- NACK if the total weight exceeds uint32_max.
markdroth
added
the
release notes: no
grpc-checks
bot
added
per-call-memory/neutral
per-channel-memory/neutral
bloat/none
labels
eugeneo
approved these changes
Jan 18, 2023
copybara-service
bot
added
the
imported
markdroth
added
release notes: yes
XuanWang-Amos
pushed a commit
to XuanWang-Amos/grpc
that referenced
this pull request
May 1, 2023
* xDS: fix WeightedClusters total weight handling * iwyu
wanlin31
pushed a commit
that referenced
this pull request
May 18, 2023
* xDS: fix WeightedClusters total weight handling * iwyu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.