Grpc.Tools: Use x86 protoc binaries on arm64 Windows #32017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonydnewell
changed the title
jtattermusch
added
the
release notes: yes
|
Within the next 24 hours after merging, a Grpc.Tools nuget with the fix should show up in https://packages.grpc.io/ (and also the daily nuget feed: https://github.com/grpc/grpc-dotnet#grpc-nuget-feed). |
copybara-service
bot
added
the
imported
|
@jtattermusch the Grpc.Tools nuget in the nightly builds has dummy binaries (zero length) for most platforms so cannot be used for testing. |
Filed #32179 |
wanlin31
pushed a commit
that referenced
this pull request
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A workaround for #31975 - use x86 protoc binaries on Windows arm64.
Unable to test as I don't have access to Windows-arm64.
Also not sure how NUnit PlatformAttribute handles arm64 (could not find any information). It is possible that tests will fail if run on Windows-arm64 with full .NET framework if NUnit doesn't distinguish between x64 and arm64 (just identifies a 64 bit platform). Not sure that we run tests on Windows-arm64.