Use correct namespace for checking if the isDefaultRootsPemSet method exists. #31580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hi, is there any possibility of getting this reviewed?
Thanks! |
dunglas
approved these changes
Jan 11, 2023
|
@stanley-cheung sorry for the ping, I'm trying to fix a bug in the client library but I have no clue how to push this forward. Do you have any advice? |
|
Thanks for the fix, any chance you can add a test for it as well? |
|
Unless you want to go for static analysis, there is not really test case for this 😅
…On Sat, 4 Mar 2023, at 7:55 PM, alto-php wrote:
Thanks for the fix, any chance you can add a test for it as well?
—
Reply to this email directly, view it on GitHub <#31580 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAECRJJYG5EHXDSXEWNUYOTW2OFYVANCNFSM6AAAAAAR2DASNA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
alto-php
approved these changes
Mar 4, 2023
frankdejonge
deleted the
php/bugfix/correct-namespace-for-method_exists-call
branch
copybara-service
bot
added
the
imported
stanley-cheung
added
the
release notes: yes
XuanWang-Amos
pushed a commit
to XuanWang-Amos/grpc
that referenced
this pull request
May 1, 2023
… exists. (grpc#31580) The `method_exists` function requires a fully qualified class name to be sent to check if a method exists. The current class was missing the namespace, which means the function always returns `false`. In our application this caused the credentials to be loaded many times over, which ate up some CPU. This bug fix ensures that this is only run once per request.
wanlin31
pushed a commit
that referenced
this pull request
May 18, 2023
… exists. (#31580) The `method_exists` function requires a fully qualified class name to be sent to check if a method exists. The current class was missing the namespace, which means the function always returns `false`. In our application this caused the credentials to be loaded many times over, which ate up some CPU. This bug fix ensures that this is only run once per request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
method_existsfunction requires a fully qualified class name to be sent to check if a method exists. The current class was missing the namespace, which means the function always returnsfalse. In our application this caused the credentials to be loaded many times over, which ate up some CPU. This bug fix ensures that this is only run once per request.