Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 1.53: Update minimum MSVC version to 2019 #32615

Merged
merged 1 commit into from Mar 14, 2023
Merged

Backport 1.53: Update minimum MSVC version to 2019 #32615

merged 1 commit into from Mar 14, 2023

Conversation

veblush
Copy link
Contributor

@veblush veblush commented Mar 14, 2023

Backport of #32614

@veblush veblush added area/documentation release notes: yes Indicates if PR needs to be in release notes labels Mar 14, 2023
@veblush veblush requested a review from markdroth March 14, 2023 00:22
@veblush veblush enabled auto-merge (squash) March 14, 2023 00:23
@veblush veblush merged commit 44a77f6 into grpc:v1.53.x Mar 14, 2023
@jtattermusch jtattermusch mentioned this pull request Mar 20, 2023
Merged
jtattermusch added a commit that referenced this pull request Mar 23, 2023
@jtattermusch
Switch all VS2017 builds to VS2019 (#32662)
43c3d1f 
(part of removing support for VS2017)

Also see #32649
Also see #32615

The switch to grpc-win2019 windows workers has already happened:
(cl/517400022).

Once this PR lands, I'll backport to 1.53.x branch as well (since that
release removes the VS2017 support).
jtattermusch added a commit to jtattermusch/grpc that referenced this pull request Mar 24, 2023
@jtattermusch
Switch all VS2017 builds to VS2019 (grpc#32662)
c426942 
(part of removing support for VS2017)

Also see grpc#32649
Also see grpc#32615

The switch to grpc-win2019 windows workers has already happened:
(cl/517400022).

Once this PR lands, I'll backport to 1.53.x branch as well (since that
release removes the VS2017 support).
XuanWang-Amos pushed a commit to XuanWang-Amos/grpc that referenced this pull request May 1, 2023
@jtattermusch @XuanWang-Amos
Switch all VS2017 builds to VS2019 (grpc#32662)
a950c4c 
(part of removing support for VS2017)

Also see grpc#32649
Also see grpc#32615

The switch to grpc-win2019 windows workers has already happened:
(cl/517400022).

Once this PR lands, I'll backport to 1.53.x branch as well (since that
release removes the VS2017 support).
wanlin31 pushed a commit that referenced this pull request May 18, 2023
@jtattermusch @wanlin31
Switch all VS2017 builds to VS2019 (#32662)
6968e78 
(part of removing support for VS2017)

Also see #32649
Also see #32615

The switch to grpc-win2019 windows workers has already happened:
(cl/517400022).

Once this PR lands, I'll backport to 1.53.x branch as well (since that
release removes the VS2017 support).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markdroth markdroth markdroth approved these changes

Assignees
No one assigned
Labels
area/documentation bloat/none lang/c++ per-call-memory/neutral per-channel-memory/neutral release notes: yes Indicates if PR needs to be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@veblush @markdroth