Merge pull request #2322 from murgatroid99/grpc-js_transport_session_ref

grpc-js: Reference session in transport when there are active calls
grpc · Jan 12, 2023 · a9f87fc · a9f87fc
2 parents 3db8acb + 7eaebaf
commit a9f87fc
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/packages/grpc-js/package.json b/packages/grpc-js/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@grpc/grpc-js",
-  "version": "1.8.3",
+  "version": "1.8.4",
   "description": "gRPC Library for Node - pure JS implementation",
   "homepage": "https://grpc.io/",
   "repository": "https://github.com/grpc/grpc-node/tree/master/packages/grpc-js",

diff --git a/packages/grpc-js/src/transport.ts b/packages/grpc-js/src/transport.ts
@@ -354,12 +354,14 @@ class Http2Transport implements Transport {
   private removeActiveCall(call: Http2SubchannelCall) {
     this.activeCalls.delete(call);
     if (this.activeCalls.size === 0 && !this.keepaliveWithoutCalls) {
+      this.session.unref();
       this.stopKeepalivePings();
     }
   }
 
   private addActiveCall(call: Http2SubchannelCall) {
     if (this.activeCalls.size === 0 && !this.keepaliveWithoutCalls) {
+      this.session.ref();
       this.startKeepalivePings();
     }
     this.activeCalls.add(call);
@@ -418,14 +420,14 @@ class Http2Transport implements Transport {
         },
         onCallEnd: status => {
           subchannelCallStatsTracker.onCallEnd?.(status);
+          this.removeActiveCall(call);
         },
         onStreamEnd: success => {
           if (success) {
             this.streamTracker.addCallSucceeded();
           } else {
             this.streamTracker.addCallFailed();
           }
-          this.removeActiveCall(call);
           subchannelCallStatsTracker.onStreamEnd?.(success);
         }
       }