Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netty: Eliminate buffer release when there is an error as caller still owns the buffer. #10537

Merged
merged 6 commits into from
Sep 15, 2023
Merged

netty: Eliminate buffer release when there is an error as caller still owns the buffer. #10537

merged 6 commits into from
Sep 15, 2023

Commits on Sep 5, 2023

  1. netty: Eliminate buffer release when there is an error as caller stil… 

    …l owns the buffer.
    @larry-safran
    larry-safran committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    80df75d View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2023

  1. Move resetting the composite reader index to before the release as it… 

    … that fails then the operation hasn't completed correctly and the ownership of the buffer should remain with the caller.
    @larry-safran
    larry-safran committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    426f1e6 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. Update netty/src/main/java/io/grpc/netty/NettyAdaptiveCumulator.java 

    Co-authored-by: Sergii Tkachenko <hi@sergii.org>
    @larry-safran @sergiitk
    larry-safran and sergiitk committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    6d97e70 View commit details
    Browse the repository at this point in the history

  2. Move release in tests from finally to catch block.

    @larry-safran
    larry-safran committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    4696ad5 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'refs/remotes/origin/is10255' into is10255

    @larry-safran
    larry-safran committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    2d4f1a2 View commit details
    Browse the repository at this point in the history

  4. Move release back to finally block in tests, but skip it if the merge… 

    …WithCompsiteTail unexpectedly succeeded.
    @larry-safran
    larry-safran committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    9a46d9e View commit details
    Browse the repository at this point in the history