Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: expose NewClient method to end users #7010

Merged
merged 17 commits into from
Mar 7, 2024
Merged

chore: expose NewClient method to end users #7010

Changes from 2 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
3575d42
chore: expose `NewClient` method to end users
bruuuuuuuce Feb 28, 2024
5455592
chore: fix build, update usages to use new NewClient naming
bruuuuuuuce Feb 28, 2024
06bb15f
fix: use dns resolver when calling NewClient directly
bruuuuuuuce Feb 29, 2024
3db24a8
chore: fix spelling error
bruuuuuuuce Feb 29, 2024
fec57e6
chore: GetDefaultSchemeOrDns -> GetDefaultSchemeOrDNS
bruuuuuuuce Feb 29, 2024
50f2e9b
fix: remove all user visisble changes aside from new NewClient func
bruuuuuuuce Mar 1, 2024
20d1967
Merge branch 'grpc:master' into patch-1
bruuuuuuuce Mar 1, 2024
5b9e5d3
fix: add internal.UserSetDefaultScheme to clientconn.go
bruuuuuuuce Mar 1, 2024
461c791
fix: unit tests failing due to default resolver being dns
bruuuuuuuce Mar 1, 2024
4884fef
Merge branch 'master' into patch-1
bruuuuuuuce Mar 6, 2024
9b16013
fix: set internal.UserSetDefaultScheme inside of SetDefaultScheme()
bruuuuuuuce Mar 6, 2024
87a7cb7
chore: run make deps
bruuuuuuuce Mar 6, 2024
d405471
chore: fix import ordering to fix build
bruuuuuuuce Mar 6, 2024
bfcfd81
chore: fix import ordering for credentials/google/xds.go
bruuuuuuuce Mar 6, 2024
6ad5013
fix: add package comment to internal/xds/xds.go file
bruuuuuuuce Mar 6, 2024
ed128db
chore: pr nits, clean up comments, reset resolver state for connectio…
bruuuuuuuce Mar 7, 2024
5938a72
Merge branch 'grpc:master' into patch-1
bruuuuuuuce Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions clientconn.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,8 @@ func (dcs *defaultConfigSelector) SelectConfig(rpcInfo iresolver.RPCInfo) (*ires
}, nil
}

// newClient returns a new client in idle mode.
func newClient(target string, opts ...DialOption) (conn *ClientConn, err error) {
// NewClient returns a new client in idle mode.
func NewClient(target string, opts ...DialOption) (conn *ClientConn, err error) {
cc := &ClientConn{
target: target,
conns: make(map[*addrConn]struct{}),
Expand Down Expand Up @@ -208,7 +208,7 @@ func newClient(target string, opts ...DialOption) (conn *ClientConn, err error)
// https://github.com/grpc/grpc/blob/master/doc/naming.md.
// e.g. to use dns resolver, a "dns:///" prefix should be applied to the target.
func DialContext(ctx context.Context, target string, opts ...DialOption) (conn *ClientConn, err error) {
cc, err := newClient(target, opts...)
cc, err := NewClient(target, opts...)
if err != nil {
return nil, err
}
Expand Down