Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream: swallow Header errors as we used to; RecvMsg can still return it #6591

Merged
merged 1 commit into from Aug 28, 2023

stream: swallow Header errors as we used to; RecvMsg can still return…

28efdf5
Select commit
Failed to load commit list.
Merged

stream: swallow Header errors as we used to; RecvMsg can still return it #6591

stream: swallow Header errors as we used to; RecvMsg can still return…
28efdf5
Select commit
Failed to load commit list.
Mergeable / Mergeable failed Feb 25, 2024 in 0s

1/3 Fail(s): DESCRIPTION

Status: FAIL

    Here are some stats of the run:
    3 validations were ran.
    2 PASSED
    1 FAILED

Details

✔️ Validator: LABEL

  • ✔️ label must include '^Type:'
    Input : Type: Bug
    Settings : {"must_include":{"regex":"^Type:"}}

❌ Validator: DESCRIPTION

  • description does not include "^RELEASE NOTES:\s([Nn][Oo][Nn][Ee]|[Nn]/[Aa]|\n(*|-)\s.+)$"**
    Input : Cherry-pick #6586 to v1.58.x branch
    Settings : {"must_include":{"regex":"^RELEASE NOTES:\\s*([Nn][Oo][Nn][Ee]|[Nn]/[Aa]|\\n(\\*|-)\\s*.+)$","regex_flag":"m"}}

✔️ Validator: MILESTONE

  • ✔️ milestone must include 'Release$'
    Input : 1.58 Release
    Settings : {"must_include":{"regex":"Release$"}}