Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: fix ClientStream.Header() behavior #6557

Merged
merged 5 commits into from Aug 18, 2023
Merged

client: fix ClientStream.Header() behavior #6557

merged 5 commits into from Aug 18, 2023

Commits on Aug 16, 2023

  1. client: fix ClientStream.Header() behavior

    This change causes us to reliably report the stream status from
    ClientStream.Header, including io.EOF in case the stream ended successfully
    with a trailers-only response.  To do this required moving the binary logging
    of trailers into clientStream.finish.
    
    By doing this, retry is also fixed in cases where an error is encountered on
    the stream before calling Header().  Previously, if Header() was called first,
    we would report ErrNoHeaders from the transport which would be converted into a
    non-error by clientStream.Header, which would then commit the RPC and prevent
    retries.  A test case was added to cover this scenario.
    dfawley committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    39f4230 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    340a371 View commit details
    Browse the repository at this point in the history
  3. remove local var

    dfawley committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    0e6d109 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2023

  1. Configuration menu
    Copy the full SHA
    11a7cd2 View commit details
    Browse the repository at this point in the history
  2. if->switch

    dfawley committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    599d7c6 View commit details
    Browse the repository at this point in the history