orca: minor cleanups #6239
orca: minor cleanups #6239
Conversation
| "errors" | ||
| "fmt" | ||
|
|
||
| ibackoff "google.golang.org/grpc/internal/backoff" |
There was a problem hiding this comment.
I think I saw Easwar comment something about import renaming with no alias/conflict and you replied with to keep it consistent with other packages that conflict with backoff. Does this apply to this?
There was a problem hiding this comment.
backoff is a top-level package so I wouldn't want to use that name. It looks like we use the more verbose "internalbackoff" in other places. This usage is existing so I'd rather just leave it alone and avoid churn.
There was a problem hiding this comment.
Ok. I always get confused with balancer/ vs. internal/balancer conflicts. Maybe we should start adopting conventions for internal packages prefixed with i.
There was a problem hiding this comment.
I'd be fine with something like that...having consistent names is always good.
ToReportPrototointernal- it was never meant to be exported / part of the ORCA API, but it is tested from another package (orca_test) so it still needs to be exported. (This is also done in orca: allow a ServerMetricsProvider to be passed to the ORCA service and ServerOption #6223, so they will technically conflict but both are ~the same.)ToReportProtoif there is no load report present. This will prevent error log spam which occurs whenever the ORCA package is imported and aDonecallback is set by a picker.RELEASE NOTES: none