Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
authz: Stdout logger #6230
authz: Stdout logger #6230
Changes from 15 commits
065089d
e17b64e
92b53a7
5665daa
95ebc88
bcf4256
b918c0a
861d9f2
270948b
8859707
c073753
c6dd904
e72bfa2
9866f61
0d9a56e
8c24380
317f501
e0800ba
e0c53d8
da716bb
7c36609
c903401
9bcb689
a1e3e7a
c74d21b
e6c450b
f60c376
8f0ad3c
6ef31dd
d663a6d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 44 in authz/audit/stdout/stdout_logger.go
GitHub Actions / tests (vet, 1.20)
Check failure on line 45 in authz/audit/stdout/stdout_logger.go
GitHub Actions / tests (vet, 1.20)
Check failure on line 48 in authz/audit/stdout/stdout_logger.go
GitHub Actions / tests (vet, 1.20)
Check failure on line 61 in authz/audit/stdout/stdout_logger.go
GitHub Actions / tests (vet, 1.20)
Check failure on line 63 in authz/audit/stdout/stdout_logger.go
GitHub Actions / tests (vet, 1.20)
Check failure on line 65 in authz/audit/stdout/stdout_logger.go
GitHub Actions / tests (vet, 1.20)
Check failure on line 68 in authz/audit/stdout/stdout_logger.go
GitHub Actions / tests (vet, 1.20)
Check failure on line 69 in authz/audit/stdout/stdout_logger.go
GitHub Actions / tests (vet, 1.20)
Check failure on line 71 in authz/audit/stdout/stdout_logger.go
GitHub Actions / tests (vet, 1.20)
Check failure on line 76 in authz/audit/stdout/stdout_logger.go
GitHub Actions / tests (vet, 1.20)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can these be moved to be inside
t.Run
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved the first two, but
log.SetFlags(0)
looks more global so I left it as isThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to have a good reason for them to be outside of
t.Run()
. I would say move everything to be inside oft.Run()
so that your sub-tests are independent of each other.