Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

authz: Rbac engine audit logging #6225

Merged
merged 106 commits into from
May 17, 2023
Merged

authz: Rbac engine audit logging #6225

merged 106 commits into from
May 17, 2023

Commits on Apr 14, 2023

  1. Add conversion of json to RBAC Audit Logging config

    @gtcooke94
    gtcooke94 committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    8b9f59a View commit details
    Browse the repository at this point in the history

  2. Swap to passing around references instead of copied values

    @gtcooke94
    gtcooke94 committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    56ab1cd View commit details
    Browse the repository at this point in the history

  3. Change v3 to v3corepb

    @gtcooke94
    gtcooke94 committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    0f3b6e7 View commit details
    Browse the repository at this point in the history

  4. go mod tidy compat=1.17

    @gtcooke94
    gtcooke94 committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    6bff58b View commit details
    Browse the repository at this point in the history

  5. go mod tidy in examples

    @gtcooke94
    gtcooke94 committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    9b3ab47 View commit details
    Browse the repository at this point in the history

  6. mod tidy

    @gtcooke94
    gtcooke94 committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    bbafb89 View commit details
    Browse the repository at this point in the history

  7. go mod tidy compat=1.17

    @gtcooke94
    gtcooke94 committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    5dad66e View commit details
    Browse the repository at this point in the history

  8. more tidy

    @gtcooke94
    gtcooke94 committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    73b1390 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2023

  1. replace panic with t.fatal

    @gtcooke94
    gtcooke94 committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    27cfe85 View commit details
    Browse the repository at this point in the history

  2. return nil when error

    @gtcooke94
    gtcooke94 committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    c8751d3 View commit details
    Browse the repository at this point in the history

  3. lowercase start of error message

    @gtcooke94
    gtcooke94 committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    441fb5c View commit details
    Browse the repository at this point in the history

  4. remove redundant change

    @gtcooke94
    gtcooke94 committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    2326e9f View commit details
    Browse the repository at this point in the history

  5. Fix test logging hard-coding problem

    @gtcooke94
    gtcooke94 committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    abcb93f View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2023

  1. Changed behavior of missing configs per PR discussion

    @gtcooke94
    gtcooke94 committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    3f57e69 View commit details
    Browse the repository at this point in the history

  2. Change parser to use map from generated proto go file

    @gtcooke94
    gtcooke94 committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    b7863ee View commit details
    Browse the repository at this point in the history

  3. ALLOW and DENY filter should get separate audit logger config

    @gtcooke94
    gtcooke94 committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    48a875e View commit details
    Browse the repository at this point in the history

  4. Small change remove and else

    @gtcooke94
    gtcooke94 committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    edf40f1 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2023

  1. Construct and allow and denyproto from the beginning

    @gtcooke94
    gtcooke94 committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    551ced9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into AuditLoggingRBACTranslator

    @gtcooke94
    gtcooke94 committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    1718c45 View commit details
    Browse the repository at this point in the history

  3. compat 1.17 in examples

    @gtcooke94
    gtcooke94 committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    dad7293 View commit details
    Browse the repository at this point in the history

  4. more 1.17 compat

    @gtcooke94
    gtcooke94 committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    7b9e96e View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2023

  1. Address PR comments

    @gtcooke94
    gtcooke94 committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    1f4c0c0 View commit details
    Browse the repository at this point in the history

  2. starting work

    @gtcooke94
    gtcooke94 committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    2eb4512 View commit details
    Browse the repository at this point in the history

  3. Move audit logger to it's own package

    @gtcooke94
    gtcooke94 committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    fd97b2c View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2023

  1. remove audit prefixes since its the package name now

    @gtcooke94
    gtcooke94 committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    ca8f66c View commit details
    Browse the repository at this point in the history

  2. Add package comment

    @gtcooke94
    gtcooke94 committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    bf571d6 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'MoveAuditPackage' into RBACEngine

    @gtcooke94
    gtcooke94 committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    49f1ff3 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into RBACEngine

    @gtcooke94
    gtcooke94 committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    066adbb View commit details
    Browse the repository at this point in the history

  5. some work

    @gtcooke94
    gtcooke94 committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    472d752 View commit details
    Browse the repository at this point in the history

  6. Shell for audit logging

    @gtcooke94
    gtcooke94 committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    66fa61a View commit details
    Browse the repository at this point in the history

  7. Continuing impl

    @gtcooke94
    gtcooke94 committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    95a5253 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2023

  1. Continuing work

    @gtcooke94
    gtcooke94 committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    67a71ff View commit details
    Browse the repository at this point in the history

  2. Adding NewChainEngine tests

    @gtcooke94
    gtcooke94 committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    1a4e978 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2023

  1. Don't create a new anonymous type every time

    @gtcooke94
    gtcooke94 committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    1a5b03d View commit details
    Browse the repository at this point in the history

  2. basic engine test

    @gtcooke94
    gtcooke94 committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    5490046 View commit details
    Browse the repository at this point in the history

  3. Working on pushing policyname through

    @gtcooke94
    gtcooke94 committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    1c4b097 View commit details
    Browse the repository at this point in the history

  4. Changing NewChainEngine to include policyName

    @gtcooke94
    gtcooke94 committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    0747d62 View commit details
    Browse the repository at this point in the history

  5. new commented tests

    @gtcooke94
    gtcooke94 committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    fa5e894 View commit details
    Browse the repository at this point in the history

  6. Renamed to NewChainEngine

    @gtcooke94
    gtcooke94 committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    b95b6f1 View commit details
    Browse the repository at this point in the history

  7. Finish renaming

    @gtcooke94
    gtcooke94 committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    9ef033b View commit details
    Browse the repository at this point in the history

  8. More tests

    @gtcooke94
    gtcooke94 committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    4896f7e View commit details
    Browse the repository at this point in the history

  9. more tests

    @gtcooke94
    gtcooke94 committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    6fb2f46 View commit details
    Browse the repository at this point in the history

  10. More comments

    @gtcooke94
    gtcooke94 committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    760f946 View commit details
    Browse the repository at this point in the history

  11. Add policyName to tests

    @gtcooke94
    gtcooke94 committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    d426edb View commit details
    Browse the repository at this point in the history

  12. merge master

    @gtcooke94
    gtcooke94 committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    5aef84f View commit details
    Browse the repository at this point in the history

  13. fix

    @gtcooke94
    gtcooke94 committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    1b60ec1 View commit details
    Browse the repository at this point in the history

  14. Cleanup

    @gtcooke94
    gtcooke94 committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    6287772 View commit details
    Browse the repository at this point in the history

  15. tests for bad cases

    @gtcooke94
    gtcooke94 committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    90a1306 View commit details
    Browse the repository at this point in the history

  16. configJson -> configJSON

    @gtcooke94
    gtcooke94 committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    bc236d9 View commit details
    Browse the repository at this point in the history

  17. Added feature and tests for handling IsOptional on unsupported logger… 

    … types
    @gtcooke94
    gtcooke94 committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    60338b3 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2023

  1. Make lines wrap shorter

    @gtcooke94
    gtcooke94 committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    c4e6067 View commit details
    Browse the repository at this point in the history

  2. Addressing PR comments

    @gtcooke94
    gtcooke94 committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    4fec2a8 View commit details
    Browse the repository at this point in the history

  3. Addressing PR comments

    @gtcooke94
    gtcooke94 committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    60088e3 View commit details
    Browse the repository at this point in the history

  4. undo rename of matchingPolicyName

    @gtcooke94
    gtcooke94 committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    50f2673 View commit details
    Browse the repository at this point in the history

  5. make builder manage the list of auditEvents

    @gtcooke94
    gtcooke94 committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    26e48ce View commit details
    Browse the repository at this point in the history

  6. Add comment in internal.go

    @gtcooke94
    gtcooke94 committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    67613d3 View commit details
    Browse the repository at this point in the history

  7. Don't use pointer to audit.Logger interface

    @gtcooke94
    gtcooke94 committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    468126a View commit details
    Browse the repository at this point in the history

  8. Change error message

    @gtcooke94
    gtcooke94 committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    4a9e3f8 View commit details
    Browse the repository at this point in the history

  9. Cleanup parsing custom config

    @gtcooke94
    gtcooke94 committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    16ea27e View commit details
    Browse the repository at this point in the history

  10. changing a name for receiver consistency

    @gtcooke94
    gtcooke94 committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    89bc833 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2023

  1. rename engine receiver -> e

    @gtcooke94
    gtcooke94 committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    938b6b9 View commit details
    Browse the repository at this point in the history

  2. Refactor audit logger option parsing to it's own func

    @gtcooke94
    gtcooke94 committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    752d9e6 View commit details
    Browse the repository at this point in the history

  3. Change to more preferred slice declaration

    @gtcooke94
    gtcooke94 committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    844216c View commit details
    Browse the repository at this point in the history

Commits on May 1, 2023

  1. Merge branch 'master' into RBACEngineAuditLogging

    @gtcooke94
    gtcooke94 committed May 1, 2023
    Configuration menu
    Copy the full SHA
    a46cd2e View commit details
    Browse the repository at this point in the history

  2. Moving to correct TypedConfig structure for custom config

    @gtcooke94
    gtcooke94 committed May 1, 2023
    Configuration menu
    Copy the full SHA
    f86c660 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2023

  1. Use TypedStruct properly for custom configs

    @gtcooke94
    gtcooke94 committed May 2, 2023
    Configuration menu
    Copy the full SHA
    cab68ba View commit details
    Browse the repository at this point in the history

  2. parse out the prefix of the name

    @gtcooke94
    gtcooke94 committed May 2, 2023
    Configuration menu
    Copy the full SHA
    21a3788 View commit details
    Browse the repository at this point in the history

  3. Move custom config logic to it's own converter.go file, setup pattern… 

    … for loading known vs. custom config
    @gtcooke94
    gtcooke94 committed May 2, 2023
    Configuration menu
    Copy the full SHA
    5e5f9e9 View commit details
    Browse the repository at this point in the history

  4. standardize imports

    @gtcooke94
    gtcooke94 committed May 2, 2023
    Configuration menu
    Copy the full SHA
    724e066 View commit details
    Browse the repository at this point in the history

  5. Change principal handling:

    @gtcooke94
    gtcooke94 committed May 2, 2023
    Configuration menu
    Copy the full SHA
    89aca52 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2023

  1. Remove extra package comment

    @gtcooke94
    gtcooke94 committed May 3, 2023
    Configuration menu
    Copy the full SHA
    1685b62 View commit details
    Browse the repository at this point in the history

  2. Rename helper functions

    @gtcooke94
    gtcooke94 committed May 3, 2023
    Configuration menu
    Copy the full SHA
    2f51981 View commit details
    Browse the repository at this point in the history

  3. fix go vet error

    @gtcooke94
    gtcooke94 committed May 3, 2023
    Configuration menu
    Copy the full SHA
    8e20f7f View commit details
    Browse the repository at this point in the history

  4. Added error cases for buildLogger

    @gtcooke94
    gtcooke94 committed May 3, 2023
    Configuration menu
    Copy the full SHA
    c5798a9 View commit details
    Browse the repository at this point in the history

  5. Actually add the new converter_test.go file

    @gtcooke94
    gtcooke94 committed May 3, 2023
    Configuration menu
    Copy the full SHA
    d35a865 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2023

  1. Remove tests that weren't being used

    @gtcooke94
    gtcooke94 committed May 4, 2023
    Configuration menu
    Copy the full SHA
    9e16b15 View commit details
    Browse the repository at this point in the history

  2. Add copyright

    @gtcooke94
    gtcooke94 committed May 4, 2023
    Configuration menu
    Copy the full SHA
    697ad75 View commit details
    Browse the repository at this point in the history

  3. git messiness, sorry

    @gtcooke94
    gtcooke94 committed May 4, 2023
    Configuration menu
    Copy the full SHA
    2bead31 View commit details
    Browse the repository at this point in the history

  4. combine if conditions

    @gtcooke94
    gtcooke94 committed May 4, 2023
    Configuration menu
    Copy the full SHA
    5ce64e9 View commit details
    Browse the repository at this point in the history

  5. Addressing PR comments

    @gtcooke94
    gtcooke94 committed May 4, 2023
    Configuration menu
    Copy the full SHA
    1402f64 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2023

  1. Address PR comments

    @gtcooke94
    gtcooke94 committed May 5, 2023
    Configuration menu
    Copy the full SHA
    ac17f03 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2023

  1. Use test name for individual loggers rather than clearing the registry

    @gtcooke94
    gtcooke94 committed May 9, 2023
    Configuration menu
    Copy the full SHA
    488c09d View commit details
    Browse the repository at this point in the history

  2. Remove internal unregister function

    @gtcooke94
    gtcooke94 committed May 9, 2023
    Configuration menu
    Copy the full SHA
    9fa7542 View commit details
    Browse the repository at this point in the history

  3. remove unregisterLoggerBuilder

    @gtcooke94
    gtcooke94 committed May 9, 2023
    Configuration menu
    Copy the full SHA
    5392f60 View commit details
    Browse the repository at this point in the history

  4. Apply punctuation suggestions from code review 

    Co-authored-by: Arvind Bright <arvind.bright100@gmail.com>
    @gtcooke94 @arvindbr8
    gtcooke94 and arvindbr8 committed May 9, 2023
    Configuration menu
    Copy the full SHA
    421acff View commit details
    Browse the repository at this point in the history

  5. %s/typedURLPrefix/typeURLPrefix

    @gtcooke94
    gtcooke94 committed May 9, 2023
    Configuration menu
    Copy the full SHA
    0960c8b View commit details
    Browse the repository at this point in the history

  6. More PR comments

    @gtcooke94
    gtcooke94 committed May 9, 2023
    Configuration menu
    Copy the full SHA
    2cb5de1 View commit details
    Browse the repository at this point in the history

  7. Merge master

    @gtcooke94
    gtcooke94 committed May 9, 2023
    Configuration menu
    Copy the full SHA
    361dcba View commit details
    Browse the repository at this point in the history

  8. Add more descriptive error in helper

    @gtcooke94
    gtcooke94 committed May 9, 2023
    Configuration menu
    Copy the full SHA
    4dd9061 View commit details
    Browse the repository at this point in the history

  9. Own TODO

    @gtcooke94
    gtcooke94 committed May 9, 2023
    Configuration menu
    Copy the full SHA
    a81070c View commit details
    Browse the repository at this point in the history

Commits on May 10, 2023

  1. Apply suggestions from code review 

    Add punctuation to comments

Co-authored-by: Arvind Bright <arvind.bright100@gmail.com>
    @gtcooke94 @arvindbr8
    gtcooke94 and arvindbr8 committed May 10, 2023
    Configuration menu
    Copy the full SHA
    50d1699 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2023

  1. Address PR comments

    @gtcooke94
    gtcooke94 committed May 15, 2023
    Configuration menu
    Copy the full SHA
    1637d73 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2023

  1. Change how we get SPIFFE ID

    @gtcooke94
    gtcooke94 committed May 16, 2023
    Configuration menu
    Copy the full SHA
    4c2b1bb View commit details
    Browse the repository at this point in the history

  2. Change missing custom config behavior

    @gtcooke94
    gtcooke94 committed May 16, 2023
    Configuration menu
    Copy the full SHA
    218ba4b View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/RBACEngineAuditLogging' into RBA… 

    …CEngineAuditLogging
    @gtcooke94
    gtcooke94 committed May 16, 2023
    Configuration menu
    Copy the full SHA
    1ec90ed View commit details
    Browse the repository at this point in the history

  4. lowercase

    @gtcooke94
    gtcooke94 committed May 16, 2023
    Configuration menu
    Copy the full SHA
    85696a7 View commit details
    Browse the repository at this point in the history

  5. Change error message

    @gtcooke94
    gtcooke94 committed May 16, 2023
    Configuration menu
    Copy the full SHA
    d8777da View commit details
    Browse the repository at this point in the history

  6. reword other errors

    @gtcooke94
    gtcooke94 committed May 16, 2023
    Configuration menu
    Copy the full SHA
    cfaf71d View commit details
    Browse the repository at this point in the history

  7. Fix test error strings

    @gtcooke94
    gtcooke94 committed May 16, 2023
    Configuration menu
    Copy the full SHA
    dd6ff8d View commit details
    Browse the repository at this point in the history

  8. handle s == nil

    @gtcooke94
    gtcooke94 committed May 16, 2023
    Configuration menu
    Copy the full SHA
    4362f75 View commit details
    Browse the repository at this point in the history

  9. use value instead of pointer

    @gtcooke94
    gtcooke94 committed May 16, 2023
    Configuration menu
    Copy the full SHA
    d582f2c View commit details
    Browse the repository at this point in the history

  10. Remove unnecessary spiffe scheme check

    @gtcooke94
    gtcooke94 committed May 16, 2023
    Configuration menu
    Copy the full SHA
    6908c86 View commit details
    Browse the repository at this point in the history

  11. Make for loop use value

    @gtcooke94
    gtcooke94 committed May 16, 2023
    Configuration menu
    Copy the full SHA
    ea8f50e View commit details
    Browse the repository at this point in the history

  12. Swap to []*auditLogger

    @gtcooke94
    gtcooke94 committed May 16, 2023
    Configuration menu
    Copy the full SHA
    dd2f2a6 View commit details
    Browse the repository at this point in the history

  13. Add check for empty audit logger name

    @gtcooke94
    gtcooke94 committed May 16, 2023
    Configuration menu
    Copy the full SHA
    52f77b8 View commit details
    Browse the repository at this point in the history

  14. Better error message

    @gtcooke94
    gtcooke94 committed May 16, 2023
    Configuration menu
    Copy the full SHA
    2f0a376 View commit details
    Browse the repository at this point in the history