Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transport: fix maxStreamID to align with http2 spec #5948

Merged
merged 2 commits into from Jan 18, 2023

Conversation

arvindbr8
Copy link
Member

@arvindbr8 arvindbr8 commented Jan 18, 2023

In this previous change, maxStreamID was set to 75% of uint32. But according to the http2 spec. Stream are identified with an unsigned 31-bit integer

This PR will fix it

RELEASE NOTES: N/A

@arvindbr8 arvindbr8 added this to the 1.53 Release milestone Jan 18, 2023
@arvindbr8 arvindbr8 linked an issue Jan 18, 2023 that may be closed by this pull request
@arvindbr8 arvindbr8 merged commit 9326362 into grpc:master Jan 18, 2023
1 check passed
@arvindbr8 arvindbr8 deleted the fixStreamIDRestart branch January 18, 2023 18:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drain client transport when stream ID approaches the max stream ID
2 participants