Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example: change name resolve example to URL style #5816

Closed
wants to merge 1 commit into from

Conversation

Smityz
Copy link

@Smityz Smityz commented Nov 24, 2022

target.Endpoint is deprecated, the example should be updated.

@Smityz Smityz changed the title example: change name resolve example to URI style example: change name resolve example to URL style Nov 24, 2022
@Smityz
Copy link
Author

Smityz commented Dec 7, 2022

@easwars Hello, can you help me to review this change?
I found #5796, maybe this PR can help to fix it.

@easwars
Copy link
Contributor

easwars commented Dec 7, 2022

As mentioned in #5796, we ideally want some sort of a helper routine to get the endpoint from a resolver.Target since the actual value could be in one of the two fields inside of the parsed `URL.

Are you interested in making that change and changing all existing usages in the code base? We don't want to update the example alone, without making changes to the existing codebase. Thanks.

@easwars
Copy link
Contributor

easwars commented Dec 7, 2022

@easwars Hello, can you help me to review this change? I found #5796, maybe this PR can help to fix it.

Apologies for the delay in getting to this review.

@Smityz
Copy link
Author

Smityz commented Dec 9, 2022

duplicated with #5852

@Smityz Smityz closed this Dec 9, 2022
@Smityz Smityz deleted the url branch December 9, 2022 03:48
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants