Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: with TLS, set TCP user timeout on the underlying raw connection (#5646) #6321

Merged
merged 2 commits into from Jun 27, 2023
Merged

server: with TLS, set TCP user timeout on the underlying raw connection (#5646) #6321

merged 2 commits into from Jun 27, 2023

Conversation

tobotg
Copy link
Contributor

@tobotg tobotg commented May 27, 2023 •
edited by dfawley

With TLS, set TCP user timeout on the underlying raw connection, and validate in tests.

Fixes #5646

RELEASE NOTES:

  • server: fix bug preventing TCP user timeout from being set on the connection when TLS is used

@dfawley dfawley self-requested a review May 31, 2023 20:16
@dfawley dfawley self-assigned this May 31, 2023
@dfawley dfawley added this to the 1.57 Release milestone Jun 2, 2023
@dfawley dfawley requested a review from ginayeh June 6, 2023 16:30
@dfawley dfawley assigned ginayeh and unassigned dfawley Jun 6, 2023
@easwars easwars merged commit e859984 into grpc:master Jun 27, 2023
11 checks passed
@crazy-max crazy-max mentioned this pull request Jul 28, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@easwars easwars easwars approved these changes

@dfawley dfawley dfawley approved these changes

@ginayeh ginayeh Awaiting requested review from ginayeh

Assignees

@ginayeh ginayeh

Labels
Type: Bug
Projects
None yet
Milestone
1.57 Release
Development

Successfully merging this pull request may close these issues.

server: with TLS, TCP user timeout is not set on the underlying connection
4 participants
@tobotg @easwars @dfawley @ginayeh