clarify comment

grpc · Jun 28, 2023 · d71350f · d71350f
1 parent 9a2ba92
commit d71350f
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/status/status.go b/status/status.go
@@ -100,7 +100,9 @@ func FromError(err error) (s *Status, ok bool) {
 	type grpcstatus interface{ GRPCStatus() *Status }
 	if gs, ok := err.(grpcstatus); ok {
 		if gs.GRPCStatus() == nil {
-			// Error has a status of OK. There is no sensible behavior for this, so map it to Unknown and discard the
+			// Error has status nil, which maps to codes.OK. There
+			// is no sensible behavior for this, so we turn it into
+			// an error with codes.Unknown and discard the existing
 			// status.
 			return New(codes.Unknown, err.Error()), false
 		}
@@ -109,8 +111,10 @@ func FromError(err error) (s *Status, ok bool) {
 	var gs grpcstatus
 	if errors.As(err, &gs) {
 		if gs.GRPCStatus() == nil {
-			// Error wraps an error that has an OK status. There is no sensible behavior for this, so map it to Unknown
-			// and discard the status.
+			// Error wraps an error that has status nil, which maps
+			// to codes.OK.  There is no sensible behavior for this,
+			// so we turn it into an error with codes.Unknown and
+			// discard the existing status.
 			return New(codes.Unknown, err.Error()), false
 		}
 		p := gs.GRPCStatus().Proto()