Resolve feedbacks.

grpc · Mar 1, 2024 · a0ce76b · a0ce76b
1 parent d9dcc72
commit a0ce76b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/internal/resolver/dns/dns_resolver_test.go b/internal/resolver/dns/dns_resolver_test.go
@@ -1225,7 +1225,7 @@ func overrideResolveTimeoutDuration(t *testing.T, dur time.Duration) {
 	t.Cleanup(func() { dnspublic.SetResolvingTimeout(origDur) })
 }
 
-// Test verifies that when the DNS resolver gets timeout error when net.Resolver
+// Test verifies that the DNS resolver gets timeout error when net.Resolver
 // takes too long to resolve a target.
 func (s) TestResolveTimeout(t *testing.T) {
 	// Set DNS resolving timeout duration to 7ms
@@ -1242,13 +1242,11 @@ func (s) TestResolveTimeout(t *testing.T) {
 	// Define a testNetResolver with lookupHostCh, an unbuffered channel,
 	// so we can block the resolver until reaching timeout.
 	tr := &testNetResolver{
-		lookupHostCh:    testutils.NewChannel(),
+		lookupHostCh:    testutils.NewChannelWithSize(0),
 		hostLookupTable: map[string][]string{target: {"1.2.3.4"}},
 	}
 	overrideNetResolver(t, tr)
 
-	// block testNetResolver.testNetResolver until timeout
-	_ = tr.lookupHostCh.SendContext(ctx, nil)
 	_, _, errCh := buildResolverWithTestClientConn(t, target)
 	select {
 	case <-ctx.Done():

diff --git a/internal/resolver/dns/fake_net_resolver_test.go b/internal/resolver/dns/fake_net_resolver_test.go
@@ -41,7 +41,7 @@ type testNetResolver struct {
 
 func (tr *testNetResolver) LookupHost(ctx context.Context, host string) ([]string, error) {
 	if tr.lookupHostCh != nil {
-		if err := tr.lookupHostCh.SendContext(ctx, nil); nil != err {
+		if err := tr.lookupHostCh.SendContext(ctx, nil); err != nil {
 			return nil, err
 		}
 	}