Skip to content

Fix reporting RpcException from server streaming error #2034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 1, 2023
Merged

Fix reporting RpcException from server streaming error #2034

merged 3 commits into from
Feb 1, 2023
+37 −0

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Feb 1, 2023 •
edited
Loading

Fixes #2032

If all of the below are true, fix throwing the status from the server in the client:

  • Channel is throwing OperationCanceledException
  • Call is made to server streaming method
  • Server streaming method returns non-OK status before streaming result
  • Client doesn't await server headers

@JamesNK
Add server streaming error test

Verified

This commit was signed with the committer’s verified signature.
JamesNK James Newton-King
GPG key ID: 0A66B2F456BF5526
Verified
Learn about vigilant mode
49c834f
@JamesNK
Clean up

Verified

This commit was signed with the committer’s verified signature.
JamesNK James Newton-King
GPG key ID: 0A66B2F456BF5526
Verified
Learn about vigilant mode
041cae5
@JamesNK JamesNK mentioned this pull request Feb 1, 2023
Closed
@JamesNK
Throw RpcException for server streaming result

Verified

This commit was signed with the committer’s verified signature.
JamesNK James Newton-King
GPG key ID: 0A66B2F456BF5526
Verified
Learn about vigilant mode
aea627e
@JamesNK JamesNK changed the title Add server streaming error test Fix reporting RpcException from server streaming error Feb 1, 2023
mgravell
mgravell approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@mgravell mgravell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine

@JamesNK JamesNK merged commit 2cdbf1c into grpc:master Feb 1, 2023
@JamesNK JamesNK deleted the jamesnk/serverstreaming-test branch February 1, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgravell mgravell

@amcasey amcasey

@BrennanConroy BrennanConroy

@ReubenBond ReubenBond

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TaskCanceledException instead of expected exception in server streaming call
2 participants
@JamesNK @mgravell