Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support zero-byte read in gRPC client #1985

Merged
merged 9 commits into from
Jan 11, 2023
Merged

Support zero-byte read in gRPC client #1985

merged 9 commits into from
Jan 11, 2023
+336 −96

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Dec 11, 2022

Avoid renting and using a buffer until a response is available using a zero-byte read of the response.

mgravell
mgravell reviewed Jan 5, 2023
View reviewed changes
Copy link
Contributor

@mgravell mgravell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(minor comments added)

@JamesNK JamesNK force-pushed the jamesnk/zero-byte-reads branch from db96ea3 to c3087ca Compare January 6, 2023 02:01
amcasey
amcasey approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@amcasey amcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sensible. To confirm my understanding of the motivation, this won't reduce renting of buffers but it will defer renting until they're actually needed, reducing contention?

@amcasey amcasey mentioned this pull request Jan 10, 2023
Merged
@JamesNK
Update test/Shared/SyncPointMemoryStream.cs

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
956964d
@JamesNK JamesNK merged commit 96ea383 into grpc:master Jan 11, 2023
@JamesNK JamesNK deleted the jamesnk/zero-byte-reads branch January 11, 2023 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgravell mgravell

@halter73 halter73

@davidfowl davidfowl

@MihaZupan MihaZupan

@amcasey amcasey

@BrennanConroy BrennanConroy

@ReubenBond ReubenBond

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@JamesNK @mgravell @halter73 @davidfowl @amcasey @MihaZupan