-
Notifications
You must be signed in to change notification settings - Fork 791
Update dotnet-grpc tool to require .NET 6 #1932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dotnet-grpc tool to require .NET 6 #1932
Conversation
@jtattermusch Nuget Build step is intermittently failing with this error:
|
} | ||
|
||
using (algorithm) | ||
using (var algorithm = SHA256.Create()) | ||
{ | ||
return algorithm.ComputeHash(stream); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return SHA256.HashData(stream);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, but SHA256.HashData
doesn't support stream: https://learn.microsoft.com/en-us/dotnet/api/system.security.cryptography.sha256.hashdata?view=net-6.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh sad, it's 7.0 https://apisof.net/catalog/e98725f1-0fcc-2eca-c31d-23e541ddcef8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I also restarted the Nuget build as there seem to have been an infrastructure flake (which should now be resolved).
…github.com/JamesNK/grpc-dotnet into jamesnk/dotnet-grpc-update-targetframework
There is a package conflict warning that I can't figure out in netcoreapp3.1. Updating the command line tool to net6.0 fixes it.
Note that .NET Core 3.1 hits end-of-life in December. See https://dotnet.microsoft.com/en-us/platform/support/policy/dotnet-core