fix: remove style node when attached to parent node in a shadow root #2558
+7
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a fix for web components that use the shadow dom.
Basically, whenever a stylesheet is removed,
document.querySelector()
is used, and this doesn't work when gridstack is used within a shadow root.To fix this, we can make use of the
styleLocation
, which describes whether we're attaching the styles in a parent node or the head of a documentChecklist
yarn test
) < I can't get tests working onmaster
either 🙈