[v14] Update github.com/stretchr/testify to latest to fix data race
#39919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joerger
added
the
no-changelog
github-actions
bot
requested review from
codingllama,
jakule,
jentfoo and
tigrato
zmb3
approved these changes
Mar 27, 2024
jentfoo
approved these changes
Mar 27, 2024
Joerger
force-pushed
the
joerger/v14/fix-testify-data-race
branch
from
6297bb0
to
74355be
Compare
tigrato
approved these changes
Mar 27, 2024
public-teleport-github-review-bot
bot
removed request for
codingllama and
jakule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version fixes a data race in
assert.EventuallyWithT- stretchr/testify#1395We saw this data race in CI here - https://github.com/gravitational/teleport/actions/runs/8455904575/job/23164471171?pr=39868.
This was done on master by dependabot - #39002