Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update electron-builder #38958

Merged
merged 2 commits into from Mar 5, 2024
Merged

Update electron-builder #38958

merged 2 commits into from Mar 5, 2024

Conversation

gzdunek
Copy link
Contributor

@gzdunek gzdunek commented Mar 5, 2024

Closes https://github.com/gravitational/teleport/security/dependabot/254

I performed the electron-builder update checklist, didn't find any issues (I only missed the point with renaming the templates to .sh.tmpl 馃槥 I guess that will have to wait until next time).

The after-install.tpl had to be updated with changes from electron-userland/electron-builder#8067.

Changelog: Updated electron-builder dependency to address possible arbitrary code execution in the Windows installer of Teleport Connect (CVE-2024-27303)

Copy link
Member

@ravicious ravicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a tag build for this? Can you add a changelog entry which mentions which CVE this closes?

@gzdunek
Copy link
Contributor Author

gzdunek commented Mar 5, 2024

Do you have a tag build for this?

Yes, 15.0.0-dev.gzdunek.9

Can you add a changelog entry which mentions which CVE this closes?

馃憤

@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from rudream March 5, 2024 15:56
@gzdunek gzdunek added this pull request to the merge queue Mar 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 5, 2024
@gzdunek gzdunek added this pull request to the merge queue Mar 5, 2024
Merged via the queue into master with commit 6176b01 Mar 5, 2024
39 checks passed
@gzdunek gzdunek deleted the gzdunek/update-electron-builder branch March 5, 2024 16:29
@public-teleport-github-review-bot

@gzdunek See the table below for backport results.

Branch Result
branch/v13 Failed
branch/v14 Create PR
branch/v15 Create PR

@gzdunek
Copy link
Contributor Author

gzdunek commented Mar 5, 2024

Ah I added the changelog entry and left no-changelog label :)

@gzdunek gzdunek removed the no-changelog Indicates that a PR does not require a changelog entry label Mar 5, 2024
gzdunek added a commit that referenced this pull request Mar 5, 2024
* Update `electron-builder` to 24.13.3

* Update `after-install.tpl`

(cherry picked from commit 6176b01)
gzdunek added a commit that referenced this pull request Mar 5, 2024
* Update `electron-builder` to 24.13.3

* Update `after-install.tpl`

(cherry picked from commit 6176b01)
github-merge-queue bot pushed a commit that referenced this pull request Mar 5, 2024
* Update `electron-builder` to 24.13.3

* Update `after-install.tpl`

(cherry picked from commit 6176b01)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants