Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batched Dependabot updates #29935

Merged
merged 9 commits into from
Aug 3, 2023
Merged

Batched Dependabot updates #29935

merged 9 commits into from
Aug 3, 2023

Conversation

@@ -194,7 +194,7 @@ require (
k8s.io/klog/v2 v2.100.1
k8s.io/kubectl v0.27.4
sigs.k8s.io/controller-runtime v0.15.0
sigs.k8s.io/controller-tools v0.12.0
sigs.k8s.io/controller-tools v0.12.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be breaking, although likely it's fine:

🐛 Change the type of markers.Collector.byPackage's key from string to *loader.Package by @​k8s-infra-cherrypick-robot in kubernetes-sigs/controller-tools#834

@codingllama
Copy link
Contributor

codingllama commented Aug 3, 2023

tool.tsh.common.TestKube/list_kube variants are failing with errors similar to the one below:

Error:

"Kube Cluster Name Labels                                                                                                                                                                  Selected 
----------------- ----------------------------------------------------------------------------------------------------------------------------------------------------------------------- -------- 
first-cluster     label1=val1 ultra_long_label_for_teleport_kubernetes_service_list_kube_clusters_method=ultra_long_label_value_for_teleport_kubernetes_service_list_kube_clusters_method          
root-cluster      label1=val1 ultra_long_label_for_teleport_kubernetes_service_list_kube_clusters_method=ultra_long_label_value_for_teleport_kubernetes_service_list_kube_clusters_method *        "

does not contain

"Kube Cluster Name Labels                                                                                                                                                                  Selected 
----------------- ----------------------------------------------------------------------------------------------------------------------------------------------------------------------- -------- 
first-cluster     label1=val1 ultra_long_label_for_teleport_kubernetes_service_list_kube_clusters_method=ultra_long_label_value_for_teleport_kubernetes_service_list_kube_clusters_method          
root-cluster      label1=val1 ultra_long_label_for_teleport_kubernetes_service_list_kube_clusters_method=ultra_long_label_value_for_teleport_kubernetes_service_list_kube_clusters_method          "

Notice the * in the "Selected" column:

  Kube Cluster Name Labels                                                                                                                                                                  Selected
  ----------------- ----------------------------------------------------------------------------------------------------------------------------------------------------------------------- --------
  first-cluster     label1=val1 ultra_long_label_for_teleport_kubernetes_service_list_kube_clusters_method=ultra_long_label_value_for_teleport_kubernetes_service_list_kube_clusters_method         
- root-cluster      label1=val1 ultra_long_label_for_teleport_kubernetes_service_list_kube_clusters_method=ultra_long_label_value_for_teleport_kubernetes_service_list_kube_clusters_method *       
+ root-cluster      label1=val1 ultra_long_label_for_teleport_kubernetes_service_list_kube_clusters_method=ultra_long_label_value_for_teleport_kubernetes_service_list_kube_clusters_method         

I think that's alright, as in we can fix the test and move on, but copying @tigrato for confirmation.

@codingllama
Copy link
Contributor

codingllama commented Aug 3, 2023

PTAL @rosstimothy @tigrato, especially at the changed kube test.

@tigrato
Copy link
Contributor

tigrato commented Aug 3, 2023

@codingllama

I think this * thing is a concurrency issue from other tests.
tsh kube ls decides the selected if the default kubeconfig $HOME/.kube/config or the value from $KUBECONFIGenv var has that cluster in the current-context.

listKube test shouldn't have the selected values. I will take a look

@codingllama
Copy link
Contributor

Thanks, @tigrato. Feel free to commit to this PR.

@codingllama
Copy link
Contributor

Alternatively we can rollback the k8s changes, let me give that a try. It may be for the best.

@codingllama
Copy link
Contributor

Actually, I'm seeing failures in other PRs, so this may have nothing to do with the version updates. I'll drop the test changes and I think we should follow up with a fix in a separate PR.

@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from tigrato August 3, 2023 18:22
@codingllama codingllama added this pull request to the merge queue Aug 3, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 3, 2023
Bumps [github.com/fsouza/fake-gcs-server](https://github.com/fsouza/fake-gcs-server) from 1.45.2 to 1.47.2.
- [Release notes](https://github.com/fsouza/fake-gcs-server/releases)
- [Commits](fsouza/fake-gcs-server@v1.45.2...v1.47.2)

---
updated-dependencies:
- dependency-name: github.com/fsouza/fake-gcs-server
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [github.com/aws/aws-sdk-go-v2/feature/dynamodb/attributevalue](https://github.com/aws/aws-sdk-go-v2) from 1.10.30 to 1.10.35.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/CHANGELOG.md)
- [Commits](aws/aws-sdk-go-v2@feature/dynamodb/attributevalue/v1.10.30...feature/dynamodb/attributevalue/v1.10.35)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/feature/dynamodb/attributevalue
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [github.com/aws/aws-sdk-go-v2/service/sqs](https://github.com/aws/aws-sdk-go-v2) from 1.23.4 to 1.24.1.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/CHANGELOG.md)
- [Commits](aws/aws-sdk-go-v2@service/ecs/v1.23.4...service/s3/v1.24.1)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/service/sqs
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) from 1.18.30 to 1.18.32.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/CHANGELOG.md)
- [Commits](aws/aws-sdk-go-v2@config/v1.18.30...config/v1.18.32)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/config
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.12.0 to 0.13.0.
- [Commits](golang/net@v0.12.0...v0.13.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [github.com/jackc/pgconn](https://github.com/jackc/pgconn) from 1.14.0 to 1.14.1.
- [Changelog](https://github.com/jackc/pgconn/blob/master/CHANGELOG.md)
- [Commits](jackc/pgconn@v1.14.0...v1.14.1)

---
updated-dependencies:
- dependency-name: github.com/jackc/pgconn
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
dependabot bot and others added 3 commits August 3, 2023 17:15
Bumps [cloud.google.com/go/container](https://github.com/googleapis/google-cloud-go) from 1.23.0 to 1.24.0.
- [Release notes](https://github.com/googleapis/google-cloud-go/releases)
- [Changelog](https://github.com/googleapis/google-cloud-go/blob/main/CHANGES.md)
- [Commits](googleapis/google-cloud-go@pubsub/v1.23.0...pubsub/v1.24.0)

---
updated-dependencies:
- dependency-name: cloud.google.com/go/container
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [sigs.k8s.io/controller-tools](https://github.com/kubernetes-sigs/controller-tools) from 0.12.0 to 0.12.1.
- [Release notes](https://github.com/kubernetes-sigs/controller-tools/releases)
- [Changelog](https://github.com/kubernetes-sigs/controller-tools/blob/master/RELEASE.md)
- [Commits](kubernetes-sigs/controller-tools@v0.12.0...v0.12.1)

---
updated-dependencies:
- dependency-name: sigs.k8s.io/controller-tools
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@codingllama codingllama added this pull request to the merge queue Aug 3, 2023
Merged via the queue into master with commit 971600e Aug 3, 2023
26 checks passed
@codingllama codingllama deleted the batched-dependabot-updates branch August 3, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants