Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud: Make full use of ID + import generation framework #1412

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

julienduchesne
Copy link
Member

Split from #1391

Convert the stack and stack_service_account resources to the new ID system that validates the ID format

Unverified

This user has not yet uploaded their public signing key.
Split from #1391
Convert the `stack` and `stack_service_account` resources to the new ID system that validates the ID format
Copy link

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically.
To do so, a Grafana Labs employee must trigger the cloud acceptance tests workflow manually.

@julienduchesne julienduchesne marked this pull request as ready for review March 11, 2024 14:33
@julienduchesne julienduchesne requested review from a team as code owners March 11, 2024 14:33
@julienduchesne julienduchesne merged commit c8ac63a into main Mar 11, 2024
26 checks passed
@julienduchesne julienduchesne deleted the julienduchesne/use-ids-more branch March 11, 2024 15:32
julienduchesne added a commit that referenced this pull request Mar 18, 2024

Unverified

This user has not yet uploaded their public signing key.
Regression from #1412
In that PR, I noticed that the ID format for the stack service account is incomplete
It contained only the SA ID, and without the stack slug, it didn't really allow for imports
I fixed it, but now read operations from the old ID format didn't work anymore

To fix this, we can support the old ID format (just the SA ID) until the next major version

This is unfortunately not testable with the acceptance test framework, but I tested it manually
julienduchesne added a commit that referenced this pull request Mar 18, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
* Fix `grafana_cloud_service_account` read
Regression from #1412
In that PR, I noticed that the ID format for the stack service account is incomplete
It contained only the SA ID, and without the stack slug, it didn't really allow for imports
I fixed it, but now read operations from the old ID format didn't work anymore

To fix this, we can support the old ID format (just the SA ID) until the next major version

This is unfortunately not testable with the acceptance test framework, but I tested it manually

* Fix SM http check test that now randomly fails
Probably new validation in the API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants