Fix metrics for GRPC streams do not correctly include tags when stream ends #3746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cchamplin
requested review from
oleiade and
olegbespalov
and removed request for
a team
|
|
There was a problem hiding this comment.
Hi @cchamplin
Good catch! Thank you for your contribution!
The change looks good to me, but it is also essential to introduce the test for it. It could be similar to something from the cmd_run_grpc_test.go, and the getSampleValues could be used to extract metrics/tags.
Do you think you could address this, or should we consider splitting a test into a separate issue or pull request?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Update the grpc stream being call to pass tags and params that include custom tags and method information
Why?
Addresses #3745
Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)
#3745
Closes #3745