[grafana] feat: add shareProcessNamespace option to restart Grafana on LDAP config changes #3569
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiayuchen888
requested review from
jkroepke,
maorfr,
torstenwalter,
Xtigyro and
zanhsieh
as code owners
|
|
jkroepke
reviewed
Feb 13, 2025
However, since there is already a merge commit on this PR, do a force push will mess-up the PR. Unless your are a git pro, I fully recommend to start from scratch here. |
…fig changes Signed-off-by: jiaychen <jiayu.chen@camptocamp.com>
jkroepke
changed the title
jkroepke
approved these changes
Feb 14, 2025
Signed-off-by: MH <zanhsieh@gmail.com>
zanhsieh
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This parameter is added because the ldap reload api is not working https://grafana.com/docs/grafana/latest/developers/http_api/admin/#reload-ldap-configuration
To allow an extraContainer to restart the Grafana container