API keys: Migrate API keys to service accounts at startup

[dmihai]

----------------------------------To be merged after 31 Jan 2025-----------------------------------

What is this feature?

This adds the functionality to migrate all API keys to service accounts for all orgs. The new function is executed at startup as part of the ServiceAccounts Service.

Why do we need this feature?

To force migrate all remaining API keys to service accounts.

Who is this feature for?

All users.

Which issue(s) does this PR fix?:

Fixes #53567.

Special notes for your reviewer:

Please check that:

• It works as expected from a user's perspective.
• If this is a pre-GA feature, it is behind a feature toggle.
• The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

[eleijonmarck]

First i thought, hmm maybe we should not migrate on startup and have a way to control it.

But this time, i feel we need to migrate on startup regardless of what happens. Users should by now have understood the change and should be ready for it

[dmihai]

First i thought, hmm maybe we should not migrate on startup and have a way to control it.

But this time, i feel we need to migrate on startup regardless of what happens. Users should by now have understood the change and should be ready for it

I thought about this as well. I think we should keep it simple and do this migration on merge. I don't see any advantage in controlling this functionality using a feature flag or similar since we want to do the migration for all users after a fixed date with no exceptions.

[dmihai]

This will be merged after 31 Jan 2025.

[github-actions]

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update or ping for review. Thank you for your contributions!

[dmihai]

Adding this comment here to prevent this PR from being closed due to no activity.

[linoman]

great job! I've added some nits that are not needed for merging

[linoman]

Suggested change

	sa.log.Debug("Migrating API keys for org", "orgId", o.ID)
	sa.log.Debug("Migrating API keys for an org", "orgId", o.ID)

[dmihai]

done

[linoman]

Suggested change

	sa.log.Warn("Some API keys failed to be migrated", "keys_total", result.Total, "keys_failed", result.Failed, "orgId", o.ID)
	sa.log.Warn("Some API keys failed to be migrated", "total_keys", result.Total, "failed_keys", result.Failed, "orgId", o.ID)

[dmihai]

done

[mgyongyosi]

LGTM 🚀