Alerting: Align notifier truncation and logging with prometheus/alertmanager #59339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexweav
added
area/alerting
alexweav
commented
Nov 25, 2022
Comment on lines
+340
to
+343
| // TruncateInBytes truncates a string to fit the given size in Bytes. | ||
| // TODO: This is more advanced than the upstream's TruncateInBytes. We should consider upstreaming this, and removing it from here. |
There was a problem hiding this comment.
Copied verbatim from webex.go. I added the TODO so we remember to do this in the future.
Prometheus's equivalent of this is also in util.go so I felt this was the place of best alignment.
alexweav
commented
Nov 25, 2022
Comment on lines
+231
to
+235
| message = strings.TrimSpace(message) | ||
| if message == "" { | ||
| // Pushover rejects empty messages. | ||
| message = "(no details)" | ||
| } |
There was a problem hiding this comment.
taken from Prometheus
|
lint error resolved in #59432 |
yuri-tceretian
approved these changes
Dec 5, 2022
|
Upstream PR is now merged, this is unblocked. Few minor changes to uptake. |
alexweav
force-pushed
the
alexweav/align-truncation
branch
from
6f2509d
to
281f1ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some external systems have limits on message sizes. Prometheus handles this in a unified way. We recently touched this area in upstream.
The way we do truncation and log is very inconsistent in Grafana notifiers, even among each other.
Why do we need this feature?
This PR aligns Grafana's notifier field truncation with upstream. We now use the same logic in the same places, same constants, and emit the same logs.
Effectively, ports prometheus/alertmanager#3135 and prometheus/alertmanager#3145 to Grafana, plus some additional alignment that was missing entirely.
Who is this feature for?
Contributes to alignment of alertmanagers.
Which issue(s) does this PR fix?:
Contributes to https://github.com/grafana/alerting-squad/issues/304
Contributes to https://github.com/grafana/alerting-squad/issues/240
Special notes for your reviewer: